This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: cilking away
- From: Mike Stump <mikestump at comcast dot net>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 17 Nov 2013 18:31:59 -0800
- Subject: Re: cilking away
- Authentication-results: sourceware.org; auth=none
- References: <2398071E-9A97-4677-9733-BD8ED3440313 at comcast dot net> <BF230D13CA30DD48930C31D4099330003A49F31B at FMSMSX101 dot amr dot corp dot intel dot com>
On Nov 15, 2013, at 8:23 PM, "Iyer, Balaji V" <balaji.v.iyer@intel.com> wrote:
> This is already done in my patch for _Cilk-spawn and _Cilk_sync support for C++. The patch was submitted ~3-4 weeks ago.
Ping once a day until reviewed. :-) You should form a new patch and post it and be sure to cc jason on that email. It is possible he just hasn't seen it yet. Be sure to post and ping the work.
> It is currently under review (http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01807.html).
I saw no evidence it is currently under review. I think the state is, jason hasn't been cced on the C++ patch and don't know of its existence.
>> The -fcilkplus in *.exp is redundant with that option in *.{c,cc}. Please
>> remove one instance of them.
>
> It is sort of like a safety measure
We don't want a sort of safety measure.
> since there are some error tests which may have dg-options omitted.
Once you decide if those test are wrong for not having dg-options, or not, the rest will just fall out.
> if it is really bad, I can put it in the tests and remove from the options.
Yes, it is really bad, thanks.