This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libbacktrace patch RFC: Look up variables in backtrace_syminfo


On Fri, Nov 15, 2013 at 01:26:54PM -0800, Ian Lance Taylor wrote:
> Jakub asked whether it would be possible to extend backtrace_syminfo to
> work for variables as well as functions.  It's a straightforward
> extension, implemented by this patch.  Bootstrapped and ran libbacktrace
> tests on x86_64-unknown-linux-gnu.  Any comments on this patch before I
> submit it?

Looks good to me.

OT,

   permanent buffer.  If THREADED is non-zero the state may be
   accessed by multiple threads simultaneously, and the library will
   use appropriate locks (this requires that the library be configured
   with --enable-backtrace-threads).  If THREADED is zero the state

in backtrace.h in backtrace_create_state comment doesn't look to be
up to date, there is no --enable-backtrace-threads it seems, just
depending on configure either it is thread safe or not (and doesn't use
locks).

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]