This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite] Add lp64 to target requirements of new IRA shrink wrapping preparation testcases


On Wed, Nov 13, 2013 at 4:17 PM, Martin Jambor <mjambor@suse.cz> wrote:
> On Wed, Nov 13, 2013 at 12:41:54PM -0800, H.J. Lu wrote:
>> On Wed, Nov 13, 2013 at 7:27 AM, Martin Jambor <mjambor@suse.cz> wrote:
>> > Hi,
>> >
>> > the testcases I have added for IRA shrink wrapping preparation code
>> > were not intended for -m32 on x86_64 and should not be tested with it,
>> > thus I'm adding lp64 to the target requirements.
>> >
>> > Let me also briefly mention that I would like to make the testcases
>> > also run on ppc64 and therefore I did not put them into
>> > gcc.target/i386.
>> >
>> > I have tested the changes by running
>> >
>> > make -k check RUNTESTFLAGS="dg.exp=ira-shrinkwrap-prep-?.c
>> > --target_board=unix/\{,32\}" and
>> > RUNTESTFLAGS="dg.exp=pr10474.c --target_board=unix/\{,32\}"
>> >
>> > and examining the gcc.sum files.  Since this was recommended by Richi
>> > on IRC, I will commit the change in a few minutes.
>> >
>> > Thanks,
>> >
>> > Martin
>> >
>> >
>> > 2013-11-13  Martin Jambor  <mjambor@suse.cz>
>> >
>> >         * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target
>> >         requirements.
>> >         * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise.
>>
>> Those 2 pass on x32.
>>
>> >         * testsuite/gcc.dg/pr10474.c: Likewise.
>> >
>>
>> This fails on x32.  Should it pass on x32?
>>
>
> I would assume all three should be ignored as UNSUPPORTED on x32 now.

The first 2 passed before this checkin.

> How exactly does it fail?
>

I got

FAIL: gcc.dg/pr10474.c scan-rtl-dump pro_and_epilogue "Performing
shrink-wrapping"

with

make check-gcc RUNTESTFLAGS="--target_board='unix{-mx32}' dg.exp=pr10474.c"

before your checkin.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]