This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, Gabriel Dos Reis <gdr at integrable-solutions dot net>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 11 Nov 2013 11:30:00 +0000
- Subject: Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY
- Authentication-results: sourceware.org; auth=none
- References: <1365105210-16552-1-git-send-email-rep dot dot dot nop at gmail dot com> <1365105210-16552-3-git-send-email-rep dot dot dot nop at gmail dot com> <CAAiZkiBiUc8=dx54kWKVjDE6sCjzyTgKUZiC65=NdVi_Mg=5rg at mail dot gmail dot com> <ydd1uapic5b dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CAAiZkiAqeHNOhkZ1FgWg1eSz4mF+9fvF1k9sLaO3hxab-X2WRg at mail dot gmail dot com> <yddwqshgx0s dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CAAiZkiDp07LpKYHZTuQ1pW0niLpZm+3qWN4J0m0=KUNKuTGa7g at mail dot gmail dot com> <CAC1BbcQQJ-W078_+ag4H2voeSCnCut9LXyG6_kBd1+nvBQX30g at mail dot gmail dot com> <CAC1BbcRsGRPJxtsi=d+T6g_8pEH0rWW0JdAPGt78U+TAV05Guw at mail dot gmail dot com> <5166AA2C dot 5090001 at oracle dot com> <CAC1BbcTPDp9eQ=HERDo5Z7W=2eYpkBwZfa=q7qm=9-5dEEtf_g at mail dot gmail dot com>
On 8 November 2013 10:29, Bernhard Reutner-Fischer wrote:
>> On 04/11/2013 02:04 PM, Bernhard Reutner-Fischer wrote:
>>>
>>> I would have expected that somebody would tell me that omitting ::tmpnam
>>> violates 27.9.2 <cstdio> from the spec but noone yelled at me yet?
std::tmpnam, like std::gets, should be killed with fire. If a target C
library doesn't provide it then I have no problem is libstdc++ doesn't
provide it either.
> Attaching an updated patch that i was using since March (without
> regressions) which takes Rainer's comments about _GLIBCXX_USE_TMPNAM
> into account.
> Ok for trunk?
Thanks for following this up.
I'm curious why you use tmpnam("NULL") rather than tmpnam(NULL) or
tmpnam("something")? Using the string literal "NULL" is a bit
confusing (although not a problem.)
How does __UCLIBC_SUSV4_LEGACY__ get defined? We'd have a problem if
users defined that at configure time but not later when using the
library.