This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] decide edge's hotness when there is profile info
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Teresa Johnson <tejohnson at google dot com>, Jan Hubicka <hubicka at ucw dot cz>, Dehao Chen <dehao at google dot com>, Xinliang David Li <davidxl at google dot com>
- Date: Sun, 10 Nov 2013 17:37:31 +0100
- Subject: Re: [PATCH] decide edge's hotness when there is profile info
- Authentication-results: sourceware.org; auth=none
- References: <CAAe5K+VJ70+Sj_J-uwcr+W6THPZXe5cy-hwtBCpJXms2=nPimg at mail dot gmail dot com> <CAAe5K+UOn4wxvwsGhy_EjiFFQMDB-emRbpNJkY5bBf6QgRJo4w at mail dot gmail dot com> <CABu31nPx18V=TZTCGe=mj=Pb+yggoK3KtuN4b1-u1LWOvxYDEQ at mail dot gmail dot com> <27686864 dot yRRoflNMFi at polaris>
On Sun, Nov 10, 2013 at 1:08 PM, Eric Botcazou wrote:
>> > +
>> > + profile_status_for_function (fn)
>> > + = (flag_guess_branch_prob ? PROFILE_GUESSED : PROFILE_ABSENT);
>> > + node->frequency
>> > + = hot ? NODE_FREQUENCY_HOT : NODE_FREQUENCY_NORMAL;
>>
>> In GCC code style the = goes at the end of the line:
>>
>> profile_status_for_function (fn)
>> (flag_guess_branch_prob ? PROFILE_GUESSED : PROFILE_ABSENT);
>> node->frequency =
>> hot ? NODE_FREQUENCY_HOT : NODE_FREQUENCY_NORMAL;
>
> Absolutely not, Teresa's version is the correct one, see reload.c for example.
Hmm, "absolutely"?
[stevenb@gcc1-power7 trunk]$ egrep -ch "^\s+= " gcc/*.[ch] | awk
'{sum=sum+$1}END{print sum}'
1797
[stevenb@gcc1-power7 trunk]$ egrep -ch "\s=$" gcc/*.[ch] | awk
'{sum=sum+$1}END{print sum}'
685
I can't find a rule/guide in the GNU or GCC coding style documents.
Anyway, not important. The "=" starting a new line is the majority, so
Theresa please forget about my comment :-)
Ciao!
Steven