This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Recent Go patch broke Alpha bootstrap
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 8 Nov 2013 10:10:43 +0100
- Subject: Re: Recent Go patch broke Alpha bootstrap
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4bOF+khsusED1tU8-tbH56CiRFhB7WKr7=mzo-eCfFmPQ at mail dot gmail dot com> <CAKOQZ8xT_+tN4uoja-9jt2j_B-39g=zWHgcsXU4FgZJjGX9kcw at mail dot gmail dot com>
On Fri, Nov 8, 2013 at 12:39 AM, Ian Lance Taylor <iant@google.com> wrote:
>> Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed:
>>
> Thanks for the patch and report. This patch should fix them.
> Bootstrapped and tested on x86_64-unknown-linux-gnu, not that that
> proves much. Committed to mainline.
With your patch, I was able to compile libgo and run libgo testsuite.
There are two new testsuite failures for newly introduced tests:
--- FAIL: TestKillStartProcess (0.00 seconds)
os_test.go:1173: Failed to build exe
/tmp/go-build420056795/main.exe: exec: "go": executable file not found
in $PATH
--- FAIL: TestKillFindProcess (0.00 seconds)
os_test.go:1173: Failed to build exe
/tmp/go-build353151102/main.exe: exec: "go": executable file not found
in $PATH
FAIL
FAIL: os
gmake[2]: *** [os/check] Error 1
This should be trivial, I have no go in $PATH (IIRC, we already have
fixed failure like this).
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x1c]
goroutine 5 [running]:
syscall.Exitsyscall
../../../gcc-svn/trunk/libgo/runtime/proc.c:1986
pprof.profileWriter
/home/uros/gcc-build/alphaev68-unknown-linux-gnu/libgo/gotest29851/test/pprof.go:600
created by runtime_pprof.StartCPUProfile
/home/uros/gcc-build/alphaev68-unknown-linux-gnu/libgo/gotest29851/test/pprof.go:594
goroutine 1 [chan receive]:
testing.RunTests
../../../gcc-svn/trunk/libgo/go/testing/testing.go:470
testing.Main
../../../gcc-svn/trunk/libgo/go/testing/testing.go:401
main.main
/home/uros/gcc-build/alphaev68-unknown-linux-gnu/libgo/gotest29851/test/_testmain.go:34
goroutine 4 [chan receive]:
pprof_test.testCPUProfile
/home/uros/gcc-build/alphaev68-unknown-linux-gnu/libgo/gotest29851/test/pprof_test.go:108
testing.tRunner
../../../gcc-svn/trunk/libgo/go/testing/testing.go:389
created by testing.RunTests
../../../gcc-svn/trunk/libgo/go/testing/testing.go:469
FAIL: runtime/pprof
gmake[2]: *** [runtime/pprof/check] Error 1
This one is new, I have to look into it a bit deeper.
All other libgo tests pass.
Uros.