This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4] rewrite simd clone argument adjustment to avoid regimplification
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: Martin Jambor <mjambor at suse dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 7 Nov 2013 16:23:35 +0100
- Subject: Re: [gomp4] rewrite simd clone argument adjustment to avoid regimplification
- Authentication-results: sourceware.org; auth=none
- References: <5277BAF0 dot 6050506 at redhat dot com> <20131104154435 dot GS27813 at tucnak dot zalov dot cz> <527AC1A8 dot 70904 at redhat dot com> <20131106224819 dot GJ27813 at tucnak dot zalov dot cz> <527AE0AF dot 2010106 at redhat dot com> <20131107073857 dot GK27813 at tucnak dot zalov dot cz> <527BAEF9 dot 2080905 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Nov 07, 2013 at 08:17:13AM -0700, Aldy Hernandez wrote:
> But as discussed on IRC, I wonder whether we can do without the
> following in the attached patch:
>
> + tree repl = make_ssa_name (TREE_TYPE (retval), NULL);
> + stmt = gimple_build_assign (repl, retval);
> + gsi_insert_before (&gsi, stmt, GSI_SAME_STMT);
> + stmt = gimple_build_assign (ref, repl);
>
> ...and unconditionally do:
>
> + stmt = gimple_build_assign (ref, retval);
This should be sufficient.
>
> ...since it seems all the GIMPLE_RETURNs I see can be replaced by
> ``retval_array[iter] = whatever'' without creating something
> non-gimple (thus avoiding an SSA variable).
>
> Either way, I'm ok. Let me know.
Thanks.
Jakub