This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion
- From: Dodji Seketeli <dodji at redhat dot com>
- To: Joshua J Cogliati <jrincayc at yahoo dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, jason at redhat dot com, manu at gcc dot gnu dot org
- Date: Tue, 05 Nov 2013 13:12:23 +0100
- Subject: Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion
- Authentication-results: sourceware.org; auth=none
- References: <52554AA2 dot 50706 at yahoo dot com> <Pine dot LNX dot 4 dot 64 dot 1310092037370 dot 12619 at digraph dot polyomino dot org dot uk> <525AA8E5 dot 807 at yahoo dot com> <87zjqcp6jx dot fsf at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1310142333000 dot 19760 at digraph dot polyomino dot org dot uk> <52613001 dot 9030606 at yahoo dot com> <Pine dot LNX dot 4 dot 64 dot 1310181516380 dot 16441 at digraph dot polyomino dot org dot uk> <52673B3E dot 3070006 at yahoo dot com> <526D1E17 dot 80001 at yahoo dot com> <87hac1rd8d dot fsf at redhat dot com> <5273D0E3 dot 1020503 at yahoo dot com>
Sorry for my late reply on this.
I just have one very small nit for one ChangeLog entry, expressed
below. If nobody objects in the next 48 hours, I'd say this is OK to
commit with the nit fixed.
I am not seeing your name in the MAINTAINERS file. Have you filed
copyright assignment to the FSF and do you have it all sorted?
Joshua J Cogliati <jrincayc@yahoo.com> writes:
> Since part of it was to go into c-family (as per Joseph S. Myers's
> email) and parts are not in c-family, I split the changelog into three
> parts. I also changed the formatting of the changelog and patch as
> per Dodji's comments. The attached patch is the same as before, but
> the diff for Wfloat-conversion.c is as a new file, not as a copy of
> Wconversion-real.c. Thanks for reviewing it. If there is anything
> else that needs changing, please tell me.
>
>
> For gcc/c-family/ChangeLog:
>
> PR c/53001
> Splitting out a -Wfloat-conversion from -Wconversion for
> conversions that lower floating point number precision
> or conversion from floating point numbers to integers
> * c-common.c (unsafe_conversion_p): Make this function
> return an enumeration with more detail.
This is nicely formatted now, thank you.
> (conversion_warning): Use the new return type of
> unsafe_conversion_p to separately warn either about conversions
> that lower floating point number precision or about the other
> kinds of conversions.
> * c-common.h: Adding conversion_safety enumeration.
> (unsafe_conversion_p): switching return type to
> conversion_safety enumeration.
Here, this should be:
* c-common.h (enum conversion_safety): New enumeration.
(unsafe_conversion_p): switching return type to
conversion_safety enumeration.
OK to commit with the above changes, if you have your copyright properly
assigned to the FSF.
Thank for working on this. It is appreciated.
--
Dodji