This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r191666
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Peter Bergner <bergner at vnet dot ibm dot com>, Jack Howarth <howarth at bromo dot med dot uc dot edu>, Alexander Potapenko <glider at google dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Dmitry Vyukov <dvyukov at google dot com>
- Date: Mon, 4 Nov 2013 22:35:06 -0800
- Subject: Re: libsanitizer merge from upstream r191666
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdzrx07_OfvCcxm_uFUt3MRhg1gwqdHvmK_9kHDmz1vPVw at mail dot gmail dot com> <CAGQ9bdxj-DmEaoo0mOWfSVXsrhVShWj3onHZRxiwt97Vq6J45w at mail dot gmail dot com> <20131029121355 dot GY30970 at tucnak dot zalov dot cz> <CAGQ9bdw+VW=yF+vaqE_0GkyHUChL_vp3cABZf-FuNYoHo3g=eg at mail dot gmail dot com> <CAGQ9bdzHaBmaTnnX3=npLngK+8K1P2EWWMX-GmOLz0S1vWcHVA at mail dot gmail dot com> <CAGQ9bdxBgJJxv2gWzAsxuECoAV_zk4TWUVGeZiAnNF1gcEQJ7g at mail dot gmail dot com> <20131030070317 dot GA27813 at tucnak dot zalov dot cz> <CAGQ9bdz1FMOngnBBmuCU4UqyTNh_jvRr0=_psZMjCpoQj6zBiQ at mail dot gmail dot com> <20131102172515 dot GA13302 at bromo dot med dot uc dot edu> <CAGQ9bdyaNob-Q_e0_YAhM9NUX3gLpj7eHD5JXfamKNGOXqa5iw at mail dot gmail dot com> <1383611584 dot 5700 dot 45 dot camel at otta> <CAGQ9bdyEu_io7ReR2HBbRdJQeHCtfidGVr85Fx4uZaS0XhCRGA at mail dot gmail dot com> <CAMe9rOpgZhSuBGwjQV=j0XL603bRkeMETy=iePK4f978CUPAOg at mail dot gmail dot com>
Is this the same failure or different?
On Mon, Nov 4, 2013 at 9:49 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> It also breaks x32 build.
>
>
> On Mon, Nov 4, 2013 at 5:48 PM, Konstantin Serebryany
> <konstantin.s.serebryany@gmail.com> wrote:
>> Hi Peter.
>> Does this also mean that asan in llvm trunk is broken for Power?
>> We'll need to fix it there too (or, in fact, first).
>>
>> --kcc
>>
>> On Mon, Nov 4, 2013 at 4:33 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
>>> On Mon, 2013-11-04 at 06:47 -0800, Konstantin Serebryany wrote:
>>>> This patch has not been tested on Mac and we generally do not claim
>>>> that gcc-asan is supported on Mac.
>>>> clang-asan *is* supported on Mac and our bots are green (this patch is
>>>> a merge of the sources which are regularly tested on Mac,
>>>> but the build procedure is different).
>>>
>>> The merge from upstream r191666 seems to have broken my
>>> powerpc64-linux build. I'm seeing:
>>>
>>> In file included from /home/bergner/gcc/gcc-fsf-mainline-base/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:21:0:
>>> /usr/include/asm/stat.h:31:2: error: ‘ino_t’ does not name a type
>>> ino_t st_ino;
>>> ^
>>> /usr/include/asm/stat.h:33:2: error: ‘nlink_t’ does not name a type
>>> nlink_t st_nlink;
>>> ^
>>> /usr/include/asm/stat.h:34:2: error: ‘mode_t’ does not name a type
>>> mode_t st_mode;
>>> ^
>>> /usr/include/asm/stat.h:39:2: error: ‘uid_t’ does not name a type
>>> uid_t st_uid;
>>> ^
>>> /usr/include/asm/stat.h:40:2: error: ‘gid_t’ does not name a type
>>> gid_t st_gid;
>>> ^
>>> /usr/include/asm/stat.h:42:2: error: ‘off_t’ does not name a type
>>> off_t st_size;
>>> ^
>>> /home/bergner/gcc/gcc-fsf-mainline-base/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:29:73: error: invalid application of ‘sizeof’ to incomplete type ‘__sanitizer::__old_kernel_stat’
>>> unsigned struct___old_kernel_stat_sz = sizeof(struct __old_kernel_stat);
>>> ^
>>> The problem seems to be that the RHEL6 system I am on, the linux/types.h
>>> kernel header file doesn't define ino_t like it does on newer systems
>>> which leads to the undefined type errors. Digging through the other kernel
>>> header files, I'm not really seeing another header file I can include
>>> to get it either. :(
>>>
>>> Peter
>>>
>>>
>
>
>
> --
> H.J.