This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] LRA: Fix incorrect register spill/reload
- From: Jeff Law <law at redhat dot com>
- To: Vladimir Makarov <vmakarov at redhat dot com>, Robert Suchanek <Robert dot Suchanek at imgtec dot com>, David Edelsohn <dje dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 04 Nov 2013 13:54:26 -0700
- Subject: Re: [PATCH] LRA: Fix incorrect register spill/reload
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvny=8tVyA-v_7x3jQ1T_Kf2aPBNCptU9RyMRXFQWYCtUC=A at mail dot gmail dot com> <B5E67142681B53468FAF6B7C313565623D34BE57 at KLMAIL01 dot kl dot imgtec dot org> <527404DC dot 3000109 at redhat dot com> <52745873 dot 7040504 at redhat dot com>
On 11/01/13 19:42, Vladimir Makarov wrote:
I did not expected from the patch any problems too. It is so obvious.
This simple change should not affect x86 (or any other target currently
using LRA). The code in question is used only for x86-64 and only for
modern intel processing tuning. It is about accuracy of using SSE regs
(regs_ever_live) which as I know affects only on saving/restoring regs
in prologue/epilogue. As all SSE_REGS are only call-clobbered, the
accuracy of this info does not affect code generation.
Agreed. It certainly caught me by surprise as well.
I suspect, the reason for your bootstrap failure was in another patch or
you use bootstrap specific options.
I didn't have any other patches in the trees I was testing. After a bit
of searching, this appears to be an ident string or something similar
with a datestamp. Certainly not a codegen issue related to this patch.
Concern withdrawn :-)
*** /tmp/J1 2013-11-04 14:05:13.810088971 -0700
--- /tmp/J2 2013-11-04 14:05:17.008088822 -0700
***************
*** 1545,1554 ****
6665 6e69 6465 2500 2b71 2044 6564 6966
0030120 n e d b u t n o t u s e d
656e 2064 7562 2074 6f6e 2074 7375 6465
! 0030140 \0 \0 \0 4 . 9 . 0 2 0 1 3 1 0
! 2000 0000 2e34 2e39 2030 3032 3331 3031
! 0030160 3 0 ( e x p e r i m e n t a l
! 3033 2820 7865 6570 6972 656d 746e 6c61
0030200 ) \0 x 8 6 _ 6 4 - u n k n o w n
0029 3878 5f36 3436 752d 6b6e 6f6e 6e77
0030220 - l i n u x - g n u \0 1 . 0 . 1
--- 1545,1554 ----
6665 6e69 6465 2500 2b71 2044 6564 6966
0030120 n e d b u t n o t u s e d
656e 2064 7562 2074 6f6e 2074 7375 6465
! 0030140 \0 \0 \0 4 . 9 . 0 2 0 1 3 1 1
! 2000 0000 2e34 2e39 2030 3032 3331 3131
! 0030160 0 1 ( e x p e r i m e n t a l
! 3130 2820 7865 6570 6972 656d 746e 6c61
0030200 ) \0 x 8 6 _ 6 4 - u n k n o w n
0029 3878 5f36 3436 752d 6b6e 6f6e 6e77
0030220 - l i n u x - g n u \0 1 . 0 . 1