This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Regex comments
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 27 Oct 2013 21:20:53 +0100
- Subject: Re: [Patch] Regex comments
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDkTYZd3zNxpast3MqiUzp5u8L1=ymAJY6qkQXu6-ywV1A at mail dot gmail dot com>
Hi,
On 10/27/2013 09:12 PM, Tim Shen wrote:
@@ -190,9 +224,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
}
break;
case _S_opcode_subexpr_begin:
- // Here's the critical part: if there's nothing changed since last
- // visit, do NOT continue. This prevents the executor from get into
- // infinite loop when use "()*" to match "".
+ // If there's nothing changed since last visit, do NOT continue.
+ // This prevents the executor from get into infinite loop when use
+ // "()*" to match "".
//
// Every change on _M_cur_results will be roll back after the
// recursion step finished.
Should we move this comment too before the 'case', and aligned with it?
Either way, patch Ok of course.
Paolo.