This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Remove "keep_aligning" from get_inner_reference
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Jambor <mjambor at suse dot cz>, Jakub Jelinek <jakub at redhat dot com>
- Date: Sun, 27 Oct 2013 17:01:53 +0100
- Subject: [PATCH] Remove "keep_aligning" from get_inner_reference
- Authentication-results: sourceware.org; auth=none
- References: <20130910193228 dot GE6732 at virgil dot suse>,<20131023171106 dot GC22314 at virgil dot suse>,<DUB122-W18EE8845FD49B5DF19B227E40C0 at phx dot gbl>,<3910341 dot 1yrhooXIjO at polaris>,<CAFiYyc0+6E5jQijgb+xVitqJZoDTy5EHNtHS2fPdVQx_BD1jUA at mail dot gmail dot com>,<DUB122-W3250D65A780768771CDEB5E40C0 at phx dot gbl>,<CAFiYyc10-KqBBJCzPqs9DJ8x0BLDyak4n5MGkKiWDyvvtQwf0g at mail dot gmail dot com>,<DUB122-W2465C900CBE219827F300CE40D0 at phx dot gbl>,<CAFiYyc0iUz1BJknJ4-kQYzB=b+ujJaUVqP=mF237brP4OJzvqw at mail dot gmail dot com>,<DUB122-W45EB12583A2B768CE9631AE40D0 at phx dot gbl>,<CAFiYyc1KcuO+HkqmDCNqehDjzj3hQBHCxKfBzqvRd7vbmyTUCg at mail dot gmail dot com>
Hi,
On Fri, 25 Oct 2013 12:51:13, Richard Biener wrote:
> Finally I think the recursion into the VIEW_CONVERT_EXPR case
> is only there because of the keep_aligning flag of get_inner_reference
> which should be obsolete now that we properly handle its effects
> in get_object_alignment. So you wouldn't need to adjust this path
> if we finally can get rid of that.
I think you are right, this flag is no longer necessary, and removing
this code path would simplify everything. Therefore I'd like to propose
to remove the "keep_aligning" parameter of get_inner_reference as
a split-out patch.
Boot-strapped (with languages=all,ada,go) and
regression-tested on x86_64-linux-gnu.
Ok for trunk?
Thanks
Bernd.
Attachment:
changelog-inner-reference.txt
Description: Text document
Attachment:
patch-inner-reference.diff
Description: Binary data
- References:
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2
- RE: [PATCH, PR 57748] Check for out of bounds access, Part 2
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2
- RE: [PATCH, PR 57748] Check for out of bounds access, Part 2
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2
- RE: [PATCH, PR 57748] Check for out of bounds access, Part 2
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2
- RE: [PATCH, PR 57748] Check for out of bounds access, Part 2
- Re: [PATCH, PR 57748] Check for out of bounds access, Part 2