This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, C++] Add C++ FE support for #pragma GCC ivdep
- From: Tobias Burnus <burnus at net-b dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 25 Oct 2013 21:27:53 +0200
- Subject: Re: [Patch, C++] Add C++ FE support for #pragma GCC ivdep
- Authentication-results: sourceware.org; auth=none
- References: <5256696F dot 7030902 at net-b dot de> <5266D084 dot 9000007 at net-b dot de> <52697263 dot 9050209 at net-b dot de> <20131025154914 dot GJ30970 at tucnak dot zalov dot cz>
Jakub Jelinek wrote:
FYI, I'm seeing various new FAILs on i686-linux:
+FAIL: gcc.dg/vect/vect-ivdep-1.c (test for warnings, line )
+FAIL: gcc.dg/vect/vect-ivdep-1.c -flto (test for warnings, line )
+FAIL: gfortran.dg/vect/vect-do-concurrent-1.f90 -O (test for warnings, line )
+FAIL: g++.dg/vect/pr33426-ivdep.cc -std=gnu++98 (test for warnings, line )
+FAIL: g++.dg/vect/pr33426-ivdep.cc -std=gnu++11 (test for warnings, line )
+/* { dg-options "-O3 -fopt-info-vec-optimized" } */
The problem is likely the same in all cases and same as I've mailed about
recently, dg-options should never be used in *.dg/vect/* testcases,
instead just use dg-additional-options, because otherwise the
required target options to enable vectorization aren't passed in.
I have now changed it to dg-additional-options. Additionally, I added a
space to the regexp to avoid the issues mentioned at
http://gcc.gnu.org/ml/gcc-patches/2013-10/msg02165.html
The current version successfully regtested with --target_board
'unix{-m32,}' on my x86_64-linux – and I also confirmed that the
dg-bogus still fails when commenting the pragma.
Committed as Rev. 204074.
Tobias
Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog (Revision 204073)
+++ gcc/testsuite/ChangeLog (Arbeitskopie)
@@ -1,3 +1,9 @@
+2013-10-25 Tobias Burnus <burnus@net-b.de>
+
+ * g++.dg/vect/pr33426-ivdep.cc: Use dg-options.
+ * gfortran.dg/vect/vect-do-concurrent-1.f90: Ditto.
+ * testsuite/gcc.dg/vect/vect-ivdep-1.c: Ditto.
+
2013-10-25 Yufeng Zhang <yufeng.zhang@arm.com>
* gcc.dg/wmul-1.c: New test.
Index: gcc/testsuite/g++.dg/vect/pr33426-ivdep.cc
===================================================================
--- gcc/testsuite/g++.dg/vect/pr33426-ivdep.cc (Revision 204073)
+++ gcc/testsuite/g++.dg/vect/pr33426-ivdep.cc (Arbeitskopie)
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target vect_float } */
-/* { dg-options "-O3 -fopt-info-vec-optimized" } */
+/* { dg-additional-options "-O3 -fopt-info-vec-optimized" } */
/* PR other/33426 */
/* Testing whether #pragma ivdep is working. */
@@ -14,6 +14,6 @@ void foo(int n, int *a, int *b, int *c, int *d, in
}
/* { dg-message "loop vectorized" "" { target *-*-* } 0 } */
-/* { dg-bogus "version" "" { target *-*-* } 0 } */
-/* { dg-bogus "alias" "" { target *-*-* } 0 } */
+/* { dg-bogus " version" "" { target *-*-* } 0 } */
+/* { dg-bogus " alias" "" { target *-*-* } 0 } */
/* { dg-final { cleanup-tree-dump "vect" } } */
Index: gcc/testsuite/gcc.dg/vect/vect-ivdep-1.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/vect-ivdep-1.c (Revision 204073)
+++ gcc/testsuite/gcc.dg/vect/vect-ivdep-1.c (Arbeitskopie)
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target vect_float } */
-/* { dg-options "-O3 -fopt-info-vec-optimized" } */
+/* { dg-additional-options "-O3 -fopt-info-vec-optimized" } */
/* PR other/33426 */
/* Testing whether #pragma ivdep is working. */
@@ -14,6 +14,6 @@ void foo(int n, int *a, int *b, int *c, int *d, in
}
/* { dg-message "loop vectorized" "" { target *-*-* } 0 } */
-/* { dg-bogus "version" "" { target *-*-* } 0 } */
-/* { dg-bogus "alias" "" { target *-*-* } 0 } */
+/* { dg-bogus " version" "" { target *-*-* } 0 } */
+/* { dg-bogus " alias" "" { target *-*-* } 0 } */
/* { dg-final { cleanup-tree-dump "vect" } } */
Index: gcc/testsuite/gfortran.dg/vect/vect-do-concurrent-1.f90
===================================================================
--- gcc/testsuite/gfortran.dg/vect/vect-do-concurrent-1.f90 (Revision 204073)
+++ gcc/testsuite/gfortran.dg/vect/vect-do-concurrent-1.f90 (Arbeitskopie)
@@ -1,6 +1,6 @@
! { dg-do compile }
! { dg-require-effective-target vect_float }
-! { dg-options "-O3 -fopt-info-vec-optimized" }
+! { dg-additional-options "-O3 -fopt-info-vec-optimized" }
subroutine test(n, a, b, c)
integer, value :: n
@@ -12,6 +12,6 @@ subroutine test(n, a, b, c)
end subroutine test
! { dg-message "loop vectorized" "" { target *-*-* } 0 }
-! { dg-bogus "version" "" { target *-*-* } 0 }
-! { dg-bogus "alias" "" { target *-*-* } 0 }
+! { dg-bogus " version" "" { target *-*-* } 0 }
+! { dg-bogus " alias" "" { target *-*-* } 0 }
! { dg-final { cleanup-tree-dump "vect" } }