This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,ARM] fix testsuite failures for arm-none-linux-gnueabihf
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Earnshaw <rearnsha at arm dot com>, Charles Baylis <charles dot baylis at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 17 Oct 2013 23:00:35 +0200
- Subject: Re: [PATCH,ARM] fix testsuite failures for arm-none-linux-gnueabihf
- Authentication-results: sourceware.org; auth=none
- References: <CADnVucADKTCGdysARNjKkUZrr+0rycGT43x3eZhqPi36=sHs=g at mail dot gmail dot com> <52123AF2 dot 7020006 at arm dot com> <CADnVucBAL5d+Qgi2M_w=X-sR84c55gkKWNgBX8Dfv1ErUVnLVA at mail dot gmail dot com> <525FBCCA dot 5060205 at arm dot com> <20131017103956 dot GD30970 at tucnak dot zalov dot cz>
Committed on Charles' behalf as rev 203799 with this ChangeLog entry:
2013-10-17 Charles Bayis <charles.baylis@linaro.org>
* gcc.dg/builtin-apply2.c: Skip test on arm hardfloat ABI targets.
* gcc.dg/tls/pr42894.c: Remove dg-options for arm*-*-* targets.
* gcc.target/arm/thumb-ltu.c: Remove dg-skip-if and require
effective target arm_thumb1_ok.
* lib/target-supports.exp
(check_effective_target_arm_fp16_ok_nocache): Don't force
-mfloat-abi=soft when building for hardfloat target.
(sorry, despite selecting 'plain text mode', gmail seems to change formatting)
Christophe.
On 17 October 2013 12:39, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Oct 17, 2013 at 11:32:42AM +0100, Richard Earnshaw wrote:
>> On 19/09/13 18:21, Charles Baylis wrote:
>> > Here is an updated version.
>> >
>> > Changelog:
>> >
>> > * gcc.dg/builtin-apply2.c: skip test on arm hardfloat ABI targets
>> > * gcc.dg/tls/pr42894.c: Remove options, forcing -mthumb fails
>> > with hardfloat, and test is not thumb-specific
>> > * gcc,target/arm/thumb-ltu.c: Avoid test failure with
>> > hardfloat ABI by requiring arm_thumb1_ok
>> > * lib/target-supports.exp
>> > (check_effective_target_arm_fp16_ok_nocache): don't force
>> > -mfloat-abi=soft when building for hardfloat target
>> >
>>
>> ChangeLogs should be formatted to 80 columns.
>
> Not only that. The descriptions should start with capital letter
> and end with a dot. For pr42894.c, you are not removing options,
> you are removing dg-options, and the rest is why, not what, so doesn't
> belong into the ChangeLog description. Similarly, for thumb-ltu.c,
> what are doing is remove dg-skip-if and require affective target
> arm_thumb1_ok.
>
> Jakub