This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0

From: Jeff Law <law at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Zhenqiang Chen <zhenqiang dot chen at arm dot com>, gcc-patches at gcc dot gnu dot org
Date: Tue, 15 Oct 2013 10:55:59 -0600
Subject: Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
Authentication-results: sourceware.org; auth=none
References: <000001ce91b3$0a947cc0$1fbd7640$ at arm dot com> <20131010111245 dot GE30970 at tucnak dot zalov dot cz> <000001cec6ef$e881b0e0$b98512a0$ at arm dot com> <20131012073934 dot GB30970 at tucnak dot zalov dot cz> <000001cec8ac$6df29e70$49d7db50$ at arm dot com> <20131014084901 dot GG30970 at tucnak dot zalov dot cz> <000001cec97c$30182720$90487560$ at arm dot com> <20131015081238 dot GL30970 at tucnak dot zalov dot cz> <525D725F dot 30308 at redhat dot com> <20131015165325 dot GQ30970 at tucnak dot zalov dot cz>

On 10/15/13 10:53, Jakub Jelinek wrote:

On Tue, Oct 15, 2013 at 10:50:39AM -0600, Jeff Law wrote:

I noticed that we're now including rtl.h and tm_p.h in
tree-ssa-reassoc.c, which seems wrong.


Isn't that required for BRANCH_COST use?
Other option would be to add some dummy wrapper around
BRANCH_COST, put that wrapper into some file that already includes rtl.h and
tm_p.h and just call it from there.

Yea, looking at it now, I'm a bit surprised this hasn't been convertedto a target hook which would avoid this problem entirely.


jeff

Follow-Ups:
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Richard Biener

References:
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jakub Jelinek
- RE: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Zhenqiang Chen
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jakub Jelinek
- RE: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Zhenqiang Chen
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jakub Jelinek
- RE: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Zhenqiang Chen
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jakub Jelinek
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jeff Law
- Re: [PATCH] Reassociate X == CST1 || X == CST2 if popcount (CST2 - CST1) == 1 into ((X - CST1) & ~(CST2 - CST1)) == 0
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]