This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix asm goto miscompilation of Linux kernel (PR middle-end/58670)
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 10 Oct 2013 09:16:12 -0700
- Subject: Re: [PATCH] Fix asm goto miscompilation of Linux kernel (PR middle-end/58670)
- Authentication-results: sourceware.org; auth=none
- References: <20131010102219 dot GC30970 at tucnak dot zalov dot cz>
On 10/10/2013 03:22 AM, Jakub Jelinek wrote:
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and 4.8?
>
> 2013-10-10 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/58670
> * stmt.c (expand_asm_operands): Add FALLTHRU_BB argument,
> if any labels are in FALLTHRU_BB, use a special label emitted
> immediately after the asm goto insn rather than label_rtx
> of the LABEL_DECL.
> (expand_asm_stmt): Adjust caller.
> * cfgrtl.c (commit_one_edge_insertion): Force splitting of
> edge if the last insn in predecessor is a jump with single successor,
> but it isn't simplejump_p.
>
> * gcc.dg/torture/pr58670.c: New test.
Ok everywhere.
r~