This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] move htab_iterator
- From: DJ Delorie <dj at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: amacleod at redhat dot com, gcc-patches at gcc dot gnu dot org, richard dot guenther at gmail dot com, jakub at redhat dot com
- Date: Tue, 1 Oct 2013 17:04:04 -0400
- Subject: Re: [patch] move htab_iterator
- Authentication-results: sourceware.org; auth=none
- References: <52499D4C dot 1040507 at redhat dot com> <8761tib8c9 dot fsf at fleche dot redhat dot com> <5249A4B7 dot 801 at redhat dot com> <87pprq9rap dot fsf at fleche dot redhat dot com> <5249B832 dot 8000504 at redhat dot com> <878uyc4u5l dot fsf at fleche dot redhat dot com>
I'm typically against adding things to libiberty "because there's no
other place for them". The purpose of libiberty is to provide a
portability layer, not a trash can. However, htab is already in
there, and the argument for putting its accessors there is sound.
However, most of the other functions in hashtab.h are of the form
htab_*(). Could these be changed to match that pattern? If these
functions are unused, it shouldn't matter to rename them. (although,
if they're unused, it shouldn't matter to discard them, either)