This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv
- From: Caroline Tice <cmtice at google dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, aoliva at redhat dot com, DJ Delorie <dj at redhat dot com>, neroden at gcc dot gnu dot org, Ralf dot Wildenhues at gmx dot de
- Date: Mon, 23 Sep 2013 11:52:47 -0700
- Subject: Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv
- Authentication-results: sourceware.org; auth=none
- References: <CABtf2+SmXMMyHSL+OuPP_YGZ-X+htUrVk00g-gdpYTc54XzAHQ at mail dot gmail dot com> <CAMe9rOo9TkVPFHfJeM2g+pCnFwtbizv+0-h5N24FHk=rqoUzxw at mail dot gmail dot com> <CABtf2+S3M=cM0yhcCkNAYZttm0TdtCm2qkbmxgD24sZGxKYnbg at mail dot gmail dot com> <CAMe9rOr8brfs-YJLdUMN7PmSnGFODb-wCTCog=Aa+nRO50U=uA at mail dot gmail dot com> <CABtf2+RWm-fyREgCi8VtKa5QvAP+Lkd8MWDnpbkPio5=g7PAWA at mail dot gmail dot com> <CABtf2+R+bjm_5z_4ip663wZE=jGP+YjBc1Qb5svkXsuhMggLFQ at mail dot gmail dot com>
(Putting into plain test for gcc-patches list).
On Mon, Sep 23, 2013 at 11:42 AM, Caroline Tice <cmtice@google.com> wrote:
>
> Ping?
>
>
> On Thu, Sep 12, 2013 at 10:44 AM, Caroline Tice <cmtice@google.com> wrote:
>>
>> On Wed, Sep 11, 2013 at 12:35 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> > On Wed, Sep 11, 2013 at 12:27 PM, Caroline Tice <cmtice@google.com>
>> > wrote:
>> >>
>> >>> 2. Why does libvtv/configure.ac have
>> >>>
>> >>> echo 'MULTISUBDIR =' >> $ac_file
>> >>> ml_norecursion=yes
>> >>> . ${multi_basedir}/config-ml.in
>> >>>
>> >>> when AM_ENABLE_MULTILIB is used? I got
>> >>>
>> >>> make[3]: Entering directory
>> >>>
>> >>> `/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libvtv'
>> >>> Makefile:844: warning: overriding recipe for target `multi-do'
>> >>> Makefile:775: warning: ignoring old recipe for target `multi-do'
>> >>> Makefile:892: warning: overriding recipe for target `multi-clean'
>> >>> Makefile:823: warning: ignoring old recipe for target `multi-clean'
>> >>>
>> >>
>> >> I do not know exactly why it was done this way, but I see that the
>> >> configure.ac files for libsanitizer and libstdc++-v3 seem to do it
>> >> exactly this way as well.
>> >
>> > They have
>> >
>> > AC_CONFIG_FILES(AC_FOREACH([DIR], [tsan], [DIR/Makefile ])
>> >
>> > libvtv has
>> >
>> > AC_CONFIG_FILES(AC_FOREACH([DIR], [. testsuite], [DIR/Makefile ]),
>> > ^ Is
>> > the extra "." needed?
>> >>
>>
>>
>> Apparently the extra "." is not needed.
>>
>> >> Are either of these issues actually causing you problems at the moment?
>> >
>> > No.
>> >
>> >
>> > --
>> > H.J.
>>
>>
>> I am attaching an updated patch that updates the configure and make
>> files in libvtv to not attempt to
>> build/run the testsuite unless --enable-vtable-verify was passed. It
>> also removes the "." that was resulting in the
>> warnings H.J. Lu mentioned. This new patch has been tested both with
>> and without --enable-vtable-verify. As I mentioned before, I would
>> appreciate someone else reviewing my patch, as a sanity check.
>> Thanks!
>>
>>
>> 2013-09-12 Caroline Tice <cmtice@google.com>
>>
>> * Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make
>> sure testsuite is not run if libstdc++ and libgcc were not built
>> with vtable verification.
>> * Makefile.in: Regenerated.
>> * configure.ac: Re-instatate checks for --enable-vtable-verify
>> flag,
>> to make sure testsuite is not run if libstdc++ and libgcc were not
>> built with vtable verification.
>> * configure: Regenerated.
>
>