This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[google, patch] Google-local version of fix for PR58312, libssp cross-compiling


Diego -

In http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00174.html I proposed
a patch to fix PR58312, which is that libssp when cross-compiled
assumes that vnsprintf is broken [1].  This is causing our libssp.so
to be missing some symbols that are referenced by some pre-existing
binaries.

The proper trunk patch from that link is going to take a good bit of
work to resolve to the point where it's ok to commit, because it needs
to handle all possible systems in an explicit list, some unknown
number of which are broken.  However, on the Google branch we only
care about glibc/Linux systems, where we know this works.

Thus, this Google-local patch addresses our immediate need in a simple
way.  Ok to commit to google/main and merge to google/gcc-4_8?

Thanks,
- Brooks


[1] For values of "broken" that are basically "some implementations
that predate the Posix standardization of the snprintf function return
a non-standard result when given overlength input."

Attachment: 2013-09-20_google-fix-libssp-config.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]