This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] match_results::format and regex_replace
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 20 Sep 2013 14:51:35 +0200
- Subject: Re: [Patch] match_results::format and regex_replace
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDmMCz62JhZkAj8KXYS-cgYqW7ADWH3+Zmy0mHRsJYQ=5w at mail dot gmail dot com>
Great indeed!
More comments later. First nit: please review the various regex_replace
overloads vs inline: if I'm not misreading the diff I see large ones
inline and small ones out of line!?! Should we have a regex.tcc?
Also, old story about ChangeLogs ;) This is not ok:
* include/bits/regex.h: Implement match_results::format and
regex_replace.
use something like:
* include/bits/regex.h (match_results::format, regex_replace):
Implement.
That is, function names *always* between round brackets.
Paolo.