This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [x86,PATCH] Simple fix for Atom LEA splitting.

From: Yuri Rumyantsev <ysrumyan at gmail dot com>
To: Uros Bizjak <ubizjak at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Igor Zamyatin <izamyatin at gmail dot com>
Date: Tue, 17 Sep 2013 12:41:59 +0400
Subject: Re: [x86,PATCH] Simple fix for Atom LEA splitting.
Authentication-results: sourceware.org; auth=none
References: <CAEoMCqSR-0sWVgxZz43LRQGCzfOVvqDNv6O6UFy_UBKOnZjUEA at mail dot gmail dot com> <CAFULd4a3SYqs4c4F7BHM9SG4HpL=58p_azcr-=MJ0Ds7u8PTGg at mail dot gmail dot com> <CAEoMCqSB6hq9RWOFtpcvcGC9dXHpAhEa4qFQs=DSmV=1tHa=_w at mail dot gmail dot com> <CAFULd4bQhehH3zPA80pbTH8ipLsO2gyi7RqPUahdoVjoDaekwg at mail dot gmail dot com> <CAEoMCqS74u+NmgUbmjB+G7Avz85FmNaC2G_aCQU1wy26yJFUQg at mail dot gmail dot com> <CAFULd4bY5fkQenMyRoHkZbPpM5bxUM1o194HPoTOPLR8mpJofw at mail dot gmail dot com>

Here is a final patch with fixed commentary.

2013/9/16 Uros Bizjak <ubizjak@gmail.com>:
> On Mon, Sep 16, 2013 at 5:01 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
>
>> Does this comment looks good to you:
>>
>>   if (start != NULL_RTX)
>>     {
>>       bb = BLOCK_FOR_INSN (start);
>>       if (start != BB_HEAD (bb))
>> /* Initialize prev to insn if insn and start belong to the same bb;
>>   in this case increase_distance can increment distance to 1.  */
>> prev = insn;
>
> I'd say something in the lines of:
>
> If insn and start belong to the same bb, set prev to insn, so the call
> to increase_distance will increase the distance between insns by 1.
>
> Best regards,
> Uros.

Attachment: fixed_patch
Description: Binary data

References:
- [x86,PATCH] Simple fix for Atom LEA splitting.
  - From: Yuri Rumyantsev
- Re: [x86,PATCH] Simple fix for Atom LEA splitting.
  - From: Uros Bizjak
- Re: [x86,PATCH] Simple fix for Atom LEA splitting.
  - From: Yuri Rumyantsev
- Re: [x86,PATCH] Simple fix for Atom LEA splitting.
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]