This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv


On Wed, Sep 11, 2013 at 12:35 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Sep 11, 2013 at 12:27 PM, Caroline Tice <cmtice@google.com> wrote:
>>
>>> 2. Why does libvtv/configure.ac have
>>>
>>>     echo 'MULTISUBDIR =' >> $ac_file
>>>     ml_norecursion=yes
>>>     . ${multi_basedir}/config-ml.in
>>>
>>> when AM_ENABLE_MULTILIB is used?  I got
>>>
>>> make[3]: Entering directory
>>> `/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libvtv'
>>> Makefile:844: warning: overriding recipe for target `multi-do'
>>> Makefile:775: warning: ignoring old recipe for target `multi-do'
>>> Makefile:892: warning: overriding recipe for target `multi-clean'
>>> Makefile:823: warning: ignoring old recipe for target `multi-clean'
>>>
>>
>> I do not know exactly why it was done this way, but I see that the
>> configure.ac files for libsanitizer and libstdc++-v3 seem to do it
>> exactly this way as well.
>
> They have
>
> AC_CONFIG_FILES(AC_FOREACH([DIR], [tsan], [DIR/Makefile ])
>
> libvtv has
>
> AC_CONFIG_FILES(AC_FOREACH([DIR], [. testsuite], [DIR/Makefile ]),
>                                                                 ^  Is
> the extra "." needed?
>>


Apparently the extra "." is not needed.

>> Are either of these issues actually causing you problems at the moment?
>
> No.
>
>
> --
> H.J.


I am attaching an updated patch that updates the configure and make
files in libvtv to not attempt to
build/run the testsuite unless --enable-vtable-verify was passed.  It
also removes the "." that was resulting in the
warnings H.J. Lu mentioned.  This new patch has been tested both with
and without --enable-vtable-verify.  As I mentioned before, I would
appreciate someone else reviewing my patch, as a sanity check.
Thanks!


2013-09-12 Caroline Tice  <cmtice@google.com>

        * Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make
        sure testsuite is not run if libstdc++ and libgcc were not built
        with vtable verification.
        * Makefile.in: Regenerated.
        * configure.ac: Re-instatate checks for --enable-vtable-verify flag,
        to make sure testsuite is not run if libstdc++ and libgcc were not
        built with vtable verification.
        * configure: Regenerated.

Attachment: libvtv-configure.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]