This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch to gcc/function] PR 58362

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Richard Biener <rguenther at suse dot de>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
Date: Mon, 09 Sep 2013 12:38:46 +0200
Subject: Re: [Patch to gcc/function] PR 58362
Authentication-results: sourceware.org; auth=none
References: <522CCF1B dot 8080007 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309090945470 dot 3869 at zhemvz dot fhfr dot qr> <522D8BBC dot 608 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309091132340 dot 3869 at zhemvz dot fhfr dot qr> <alpine dot LNX dot 2 dot 00 dot 1309091136460 dot 3869 at zhemvz dot fhfr dot qr>

On 09/09/2013 11:37 AM, Richard Biener wrote:

That said, grepping for %q+D reveals quite some uses and it looks like
all of them expect the location being used to be that of the decl passed
to the diagnostic call, not some random other location.

If the decl is *not* a PARM_DECL, I expect %q+D to be often accurate. Infact, even when *is* a PARM_DECL what we have now is pretty decent,because normally the location of the corresponding FUNCTION_DECL isn'tthat far. The point is whether we want to be *more* accurate and pointto the specific unused parameter, for C and C++, as clang and icc do.


Paolo.

Follow-Ups:
- Re: [Patch to gcc/function] PR 58362
  - From: Jakub Jelinek
- Re: [Patch to gcc/function] PR 58362
  - From: Gabriel Dos Reis

References:
- [Patch to gcc/function] PR 58362
  - From: Paolo Carlini
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener
- Re: [Patch to gcc/function] PR 58362
  - From: Paolo Carlini
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]