This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ubsan] Use pointer map instead of hash table.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 28 Aug 2013 15:37:31 +0200
- Subject: Re: [ubsan] Use pointer map instead of hash table.
- Authentication-results: sourceware.org; auth=none
- References: <20130827123338 dot GA574 at redhat dot com> <CAFiYyc1VL-yEAjuhbrPMthnak6u48yN+Rm1LnLRVV18RpXx0PA at mail dot gmail dot com> <20130828121543 dot GD574 at redhat dot com> <CAFiYyc32h_fAZfgkvhfOO-Pr1zzgsYo7A+WCgFAR=gorOVyG4Q at mail dot gmail dot com> <20130828125701 dot GF574 at redhat dot com> <20130828130537 dot GV21876 at tucnak dot zalov dot cz> <20130828133046 dot GG574 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Aug 28, 2013 at 03:30:46PM +0200, Marek Polacek wrote:
> >From a quick look, it doesn't seem like we do. (I was searching for
> something about pointer_map in ggc* and gen* files.)
If we can't make it GC aware easily, I'm afraid we need to revert that change to
pointer_map. Now, the question is if the if_marked stuff can be easily done
for the previous implementation with C++ish hash table, or if we should just
use something similar to what tree.c uses for value_expr_for_decl and
similar (of course, with minor adjustments, because we want to map from
TYPE_UID rather than DECL_UID of the key to tree). Or with pointer_map we'd
need to push both the keys (types) and what they map to into (decls) into
some GC vector in addition to the pointer_map.
Jakub