This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> -----Original Message----- > From: Jason Merrill [mailto:jason@redhat.com] > Sent: Monday, August 19, 2013 10:46 AM > To: Iyer, Balaji V; Rainer Orth > Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek > (polacek@redhat.com) > Subject: Re: [PATCH] Fix for PR c/57490 > > On 08/19/2013 10:37 AM, Iyer, Balaji V wrote: > > I just want to make sure I get what you are saying. Are you suggesting > that I do this in finish_call_expr() instead of cp_build_binary_op() ? > > I think build_cxx_call is the right place. Attached, please find a fixed patch as you suggested. Is this Ok for trunk? Here is the ChangeLog entries. gcc/cp/ChangeLog 2013-08-19 Balaji V. Iyer <balaji.v.iyer@intel.com> PR c/57490 * cp-array-notation.c (cp_expand_cond_array_notations): Added a check for truth values. (expand_array_notation_exprs): Added truth values case. Removed an unwanted else. Added for-loop to walk through subtrees in default case. * call.c (build_cxx_call): Inherited the type of the array notation for certain built-in array notation functions. gcc/c/ChangeLog 2013-08-19 Balaji V. Iyer <balaji.v.iyer@intel.com> PR c/57490 * c-array-notation.c (fix_conditional_array_notations_1): Added a check for truth values. (expand_array_notation_exprs): Added truth values case. Removed an unwanted else. Added for-loop to walk through subtrees in default case. gcc/testsuite/ChangeLog 2013-08-19 Balaji V. Iyer <balaji.v.iyer@intel.com> PR c/57490 * c-c++-common/cilk-plus/AN/pr57490.c: New test. > > Jason >
Attachment:
patch_pr57490.txt
Description: patch_pr57490.txt
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |