This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libstdc++]: Avoid -Wcast-qual warnings in src/c++98/compatibility.cc
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Wed, 14 Aug 2013 16:36:31 +0200
- Subject: Re: [PATCH, libstdc++]: Avoid -Wcast-qual warnings in src/c++98/compatibility.cc
- References: <CAFULd4b1wMYmGosnnoCR_f3-hTjc2g0V1PAVKKCwzpEjLcQ1=Q at mail dot gmail dot com> <5202C08B dot 7060002 at oracle dot com> <20130814082909 dot GM1814 at tucnak dot redhat dot com> <CAAiZkiBdnZo6mnje5V28m3R3+dXrw0Vt2bJfz3C6n_=mDxp0XA at mail dot gmail dot com> <CAFULd4ZU8TUf+VZ8=mdwpinKN7tT9TY==2K_NBZrzj-KSvctng at mail dot gmail dot com> <CAAiZkiAonAjXbx9CO4+Yj5U17xr2Yxu7oSbuo-mfx_LrHj-u=Q at mail dot gmail dot com>
On Wed, Aug 14, 2013 at 4:34 PM, Gabriel Dos Reis
<gdr@integrable-solutions.net> wrote:
> On Wed, Aug 14, 2013 at 9:22 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>> On Wed, Aug 14, 2013 at 4:05 PM, Gabriel Dos Reis
>> <gdr@integrable-solutions.net> wrote:
>> > I agree 'const void*' is preferable, and all the places you mention should
>> > be covered too.
>>
>> I already installed my original patch, so attached incremental patch
>> implements preferred solution.
>>
>> 2013-08-14 Uros Bizjak <ubizjak@gmail.com>
>>
>> * src/c++98/compatibility.cc (_ZTIe): Use (const cast *)
>> to avoid -Wcast-qual warnings.
>> (_ZTIPe): Ditto.
>> (ZTIPKe): Ditto.
>>
>> Tested on alphaev68-pc-linux-gnu and installed on mainline SVN.
>>
>> Is this solution also OK for other release branches?
>>
>> Uros.
>
> Sorry, when I said 'const void*' was OK, I implicitly assumed that you would
> use C++-style cast reinterpret_cast<const void*>(_Z….). Same for
> reinterpret_cast<const void*>(1);
Ah, OK. I'll add this in a moment.
Thanks,
Uros.