This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Support using 'auto' in a function parameter list to introduce an implicit template parameter.


On 12.08.2013 17:00, Jason Merrill wrote:
On 08/11/2013 03:49 PM, Adam Butcher wrote:
+#define fully_implicit_template scope_chain->x_fully_implicit_template

Why did you choose to add this to saved_scope rather than cp_parser?
It seems like state that could be local to the parser rather than
shared with the rest of the compiler.

Currently it is the implicit function template code in pt.c that updates this; specifically add_implicit_template_parms and finish_fully_implicit_template.

It is queried by the parser (both in parser.c and lambda.c) to decide whether a new [implicit] template parameter list as been started and to decide how to finish up.

I had a look into this; it should be possible to move these out of pt.c and into parser.c (or some new file generic-parms.c, implicit-pt.c or some such) and possibly add a plain global counter for this state, rather than attribute it to each scope.

+tree type_uses_auto (tree type)
+tree type_uses_auto_or_concept (tree type)

Function name at the beginning of the line.

Fixed.

Adam


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]