RE: [PATCH] Fix for PR c/57490

["Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>]

> -----Original Message-----
> From: Rainer Orth [mailto:ro@CeBiTec.Uni-Bielefeld.DE]
> Sent: Friday, August 09, 2013 7:54 AM
> To: Iyer, Balaji V
> Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek
> (polacek@redhat.com)
> Subject: Re: [PATCH] Fix for PR c/57490
> 
> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> 
> > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> >
> >> "Iyer, Balaji V" <balaji.v.iyer@intel.com> writes:
> >>
> >>>> -----Original Message-----
> >>>> From: Jakub Jelinek [mailto:jakub@redhat.com]
> >>>> Sent: Monday, July 01, 2013 1:09 PM
> >>>> To: Iyer, Balaji V
> >>>> Cc: gcc-patches@gcc.gnu.org; Rainer Orth
> >>>> Subject: Re: [PATCH] Fix for PR c/57490
> >>>>
> >>>> On Mon, Jul 01, 2013 at 05:02:57PM +0000, Iyer, Balaji V wrote:
> >>>> > OK. The fixed patch is attached. Here are the ChangeLog entries:
> >>>> >
> >>>> > gcc/cp/ChangeLog
> >>>> > 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> >>>> >
> >>>>
> >>>> Still
> >>>> 	PR c/57490
> >>>> hasn't been added to cp/ChangeLog and c/ChangeLog entries.
> >>>> > --- /dev/null
> >>>> > +++ b/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c
> >>>> > @@ -0,0 +1,25 @@
> >>>>
> >>>
> >>> Fixed as you suggested. Here is the fixed Changelogs and patch is attached.
> >>>
> >>> gcc/cp/ChangeLog
> >>> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> >>>
> >>>         PR c/57490
> >>>         * cp-array-notation.c (cp_expand_cond_array_notations): Added a
> >>>         check for truth values.
> >>>         (expand_array_notation_exprs): Added truth values case.  Removed an
> >>>         unwanted else.  Added for-loop to walk through subtrees in default
> >>>         case.
> >>>
> >>> gcc/c/ChangeLog
> >>> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> >>>
> >>>         PR c/57490
> >>>         * c-array-notation.c (fix_conditional_array_notations_1): Added a
> >>>         check for truth values.
> >>>         (expand_array_notation_exprs): Added truth values case.  Removed an
> >>>         unwanted else.  Added for-loop to walk through subtrees in default
> >>>         case.
> >>>
> >>>
> >>> gcc/testsuite/ChangeLog
> >>> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> >>>
> >>>         PR c/57490
> >>>         * c-c++-common/cilk-plus/AN/pr57490.c: New test.
> >>
> >> I've just tested this patch on i386-pc-solaris2.10:
> >>
> >> The c-c++-common/cilk-plus/AN/an-if.c test still FAILs for C++:
> >>
> >> FAIL: c-c++-common/cilk-plus/AN/an-if.c  -fcilkplus (internal
> >> compiler error)
> >> FAIL: c-c++-common/cilk-plus/AN/an-if.c  -fcilkplus (test for excess
> >> errors)
> [...]
> > This is still unfixed almost three weeks later.  Balaji, could you
> > please have a look?
> 
> This bug is now unfixed for two months, and no reaction whatsoever on the
> report.  This is getting annoying since it generates large amount of testsuite
> noise.
> 
> Please fix ASAP!
> 

Hi Rainer,

   First off, my sincerest apologies for letting this bug slip the cracks. I am attaching a patch that seem to work fine with the .i file that you have submitted in bugzilla for both C and C++. Please let me know if this fix works for you and if it is OK for trunk.

Here are the Changelog entries:
gcc/c/ChangeLog
2013-08-12  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        PR c/57490
        * c-array-notation.c (fix_conditional_array_notations_1): Added a
        check for truth values.
        (expand_array_notation_exprs): Added truth values case.  Removed an
        unwanted else.  Added for-loop to walk through subtrees in default
        case.

gcc/cp/ChangeLog
2013-08-12  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        PR c/57490
        * cp-array-notation.c (cp_expand_cond_array_notations): Added a
        check for truth values.
        (expand_array_notation_exprs): Added truth values case.  Removed an
        unwanted else.  Added for-loop to walk through subtrees in default
        case.
        * typeck.c (cp_build_binary_op): Inherited the type of the array
        notation for built-in array notation functions.

gcc/testsuite/ChangeLog
2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        PR c/57490
        * c-c++-common/cilk-plus/AN/pr57490.c: New test.


Yours sincerely,

Balaji V. Iyer.


> 	Rainer
> 
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University

Attachment: patch_pr57490.txt
Description: patch_pr57490.txt