This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++14/lambda] Experimental polymorphic lambda patches
- From: Adam Butcher <adam at jessamine dot co dot uk>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Sun, 04 Aug 2013 23:52:39 +0100
- Subject: Re: [C++14/lambda] Experimental polymorphic lambda patches
- References: <1372721221-6201-1-git-send-email-adam at jessamine dot co dot uk> <51FD4E0B dot 1040602 at oracle dot com>
Hi Paolo,
On 03.08.2013 19:38, Paolo Carlini wrote:
.. I don't know if at this Stage we are paying attention to these
minor details, but at least Patch 1 and 3 appear to have some
overlong
lines.
The patch set referenced by your mail has been superseded (see [1] and
[2]). I think most of the overlong lines were review queries or partial
implementation which have now gone away. I will ensure prior to
submitting a final set that changelogs are done and that, to the best of
my knowledge, the code style guidelines are followed.
For future, is there a convention for the mail 'Subject' that I should
use to make it clear that I'm requesting feedback rather than expecting
to get the patch committed as is? "RFC" rather than "PATCH" perhaps? I
have simply been omitting changelogs in the commit logs for "non-final"
patches.
Cheers,
Adam
[1] http://gcc.gnu.org/ml/gcc-patches/2013-07/threads.html#00755
[2] http://gcc.gnu.org/ml/gcc-patches/2013-08/threads.html#00130