This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Fix unrecognizable vector comparisons

From: Zhenqiang Chen <zhenqiang dot chen at linaro dot org>
To: Jakub Jelinek <jakub at redhat dot com>, janisjo at codesourcery dot com, ramrad01 at arm dot com, James Greenhalgh <james dot greenhalgh at arm dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Thu, 1 Aug 2013 10:04:23 +0800
Subject: Re: [PATCH, ARM] Fix unrecognizable vector comparisons
References: <CACgzC7B3jDU3jo1LRYzvQsTkn7hxRYs=LrOjMg5m_f+wEnOqCw at mail dot gmail dot com> <51C02B34 dot 7050104 at arm dot com> <CACgzC7Ah7+rBUXCej2dHD3y-oVtpgrRKMA9y+e=h7jEk=ZmLOQ at mail dot gmail dot com> <CAJA7tRZkppiejXrdzKN+OVv3qk+ohy=Pt1ZB4cR8TU2U7iz+tg at mail dot gmail dot com> <CACgzC7DrGgtEunT5C84b2vvzdSEcd2SJbX3bQP-ToiQKVAytWw at mail dot gmail dot com> <51DB0874 dot 8060109 at mentor dot com> <20130708184946 dot GA2475 at laptop dot redhat dot com>

Thank you all for the comments. The patch is updated as:
1) Revert it to the original one.
2) For the testcase, replace the dg-options with
/* { dg-do compile } */
/* { dg-require-effective-target arm_neon } */
/* { dg-add-options arm_neon } */
/* { dg-options "-O3" } */

Bootstrap on Chromebook and Pandaboard.
No make check regression on Pandaboard.

Thanks!
-Zhenqiang

On 9 July 2013 02:49, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Jul 08, 2013 at 11:44:04AM -0700, Janis Johnson wrote:
>> >> @@ -0,0 +1,16 @@
>> >> +/* { dg-do compile } */
>> >> +/* { dg-options "-O3 -mfpu=neon -mcpu=cortex-a9 -mthumb
>> >> -mfloat-abi=hard -S" } */
>> >>
>> >> dg-add-options arm_neon ?
>> >> dg-require-effective-target arm_neon ?
>> >
>> > I will update it.
>>
>> Please skip the test for multilibs whose flags include -mfpu or -mcpu options,
>> which would conflict with or override the options in the test.
>
> Also the -S in dg-options looks wrong.  That should be derived from dg-do.
>
>         Jakub

Attachment: neon-update3.patch
Description: Binary data

Follow-Ups:
- [Ping] Re: [PATCH, ARM] Fix unrecognizable vector comparisons
  - From: Zhenqiang Chen
- Re: [PATCH, ARM] Fix unrecognizable vector comparisons
  - From: Ramana Radhakrishnan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]