This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, PR 57811] Wasted work in find_reloads()
- From: Marek Polacek <polacek at redhat dot com>
- To: pchang9 at cs dot wisc dot edu
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 22 Jul 2013 18:50:00 +0200
- Subject: Re: [Patch, PR 57811] Wasted work in find_reloads()
- References: <f6fa3dffff7104c33468fe621c337c72 dot squirrel at webmail dot cs dot wisc dot edu>
On Mon, Jul 22, 2013 at 11:39:38AM -0500, pchang9@cs.wisc.edu wrote:
> Hi,
>
> The problem appears in revision 201034 in version 4.9. I attached
> one-line patches that fixes it. I also reported this problem
> at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57811
>
> Bootstrap and regression-tested on x86_64-linux.
>
> In method "find_reloads()" in gcc/reload.c, the loop on line 3324 should
> break immediately after "badop" is set to "1". Also, the loop on line 4641
> should break after "ok" is set to "0".
>
>
> 2013-07-22 Chang <pchang9@cs.wisc.edu>
>
> * reload.c (find_reloads): Exit loop once we find this operand
> cannot be reloaded somehow for this alternative.
>
> * reload.c (find_reloads): Exit loop once we find a
> hard register.
Perhaps just
2013-07-22 Chang <pchang9@cs.wisc.edu>
* reload.c (find_reloads): Exit loop after setting badop.
Exit loop after setting ok.
Otherwise looks ok, just note that your MTA mangled the second patch.
Marek