This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types


 Sorry, I haven't found time for this until now.

On Sunday 14 of July 2013, Jason Merrill wrote:
> On 07/08/2013 10:32 AM, Jason Merrill wrote:
> > Was it a deliberate decision to put this in the c-common attributes
> > rather than the C++-specific ones?  I'm not saying it's wrong, just
> > interested in your thinking.
>
> I think it makes sense to leave it in c-common so that types shared
> between C and C++ can use it without a warning.

 Given the types need to have a ctor/dtor in order for this warning to make 
sense, this should not be needed. I actually didn't put it in c-common 
attributes on purpuse, I just based it on another attribute without realizing 
there was place elsewhere for C++-specific ones. I can write a patch to move 
this if wanted.

> I've fixed up the other issues and am applying this patch:

 Thanks a lot.

 As for the copyright assignment, AFAIK there is a generic SUSE one that 
should cover this as well.

-- 
 Lubos Lunak
 l.lunak@suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]