[PING][PING][PATCH] for for c/PR57541

["Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>]

Did anyone get a chance to look at this? If so, is this OK for trunk? It is a relatively minor change...

Thanks,


-Balaji V. Iyer.

> -----Original Message-----
> From: Iyer, Balaji V
> Sent: Tuesday, July 02, 2013 1:07 PM
> To: gcc-patches@gcc.gnu.org
> Cc: rth@redhat.com
> Subject: FW: [PING][PATCH] for for c/PR57541
> 
> Hello everyone,
> 	Is this Patch OK for trunk?
> 
> -Balaji V. Iyer.
> 
> > -----Original Message-----
> > From: Iyer, Balaji V
> > Sent: Monday, June 17, 2013 8:10 AM
> > To: gcc-patches@gcc.gnu.org
> > Subject: [PING][PATCH] for for c/PR57541
> >
> > Hello Everyone,
> > 	Is this patch OK for trunk?
> >
> > Thanks,
> >
> > Balaji V. Iyer.
> >
> > > -----Original Message-----
> > > From: Iyer, Balaji V
> > > Sent: Wednesday, June 12, 2013 1:22 PM
> > > To: gcc-patches@gcc.gnu.org
> > > Cc: anna.m.tikhonova@gmail.com
> > > Subject: [PATCH] for for c/PR57541
> > >
> > > Hello Everyone,
> > > 	Attach, please find a patch that will fix the issues in C/PR57541.
> > > The issue reported was that the parameters passed into the builtin
> > > array notation reduction functions were not checked correctly. This
> > > patch
> > should fix that issue.
> > > It is tested on x86 and x86_64 and it seem to pass all the tests. I
> > > have also included a testsuite.
> > >
> > > Here are the ChangeLog entries:
> > >
> > > gcc/c/ChangeLog
> > > 2013-06-12  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > >
> > >         * c-array-notation.c (fix_builtin_array_notation_fn): Added a call to
> > >         valid_no_reduce_fn_params_p and valid_reduce_fn_params_p.
> > >         (build_array_notation_expr): Added a check for capturing the return
> > >         value (i.e. void) of __sec_reduce_mutating function.
> > >
> > >
> > > gcc/c-family/ChangeLog:
> > > 2013-06-12  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > >
> > >         * array-notation-common.c (valid_reduce_fn_params_p): New function.
> > >         (valid_no_reduce_fn_params_p): Likewise.
> > >         * c-common.h (valid_reduce_fn_params_p): Added a new prototype.
> > >         (valid_no_reduce_fn_params_p): Likewise.
> > >
> > > gcc/testsuite/ChangeLog
> > > 2013-06-12  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > >
> > >         PR c/57541
> > >         * c-c++-common/cilk-plus/AN/pr57541-2.c: New test.
> > >         * c-c++-common/cilk-plus/AN/rank_mismatch2.c: Fixed a bug by
> replacing
> > >         a comma with an operation.
> > >
> > >
> > > Thanks,
> > >
> > > Balaji V. Iyer.

Attachment: patch_pr57541.txt
Description: patch_pr57541.txt