This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ Patch] PR 14263


Paolo Carlini <paolo.carlini@oracle.com> writes:

| Hi,
| 
| this issue dates back to 2004 and got stalled pretty soon. Essentially
| Gaby wanted to see *dynamic_cast* explicitly mentioned in this kind of
| diagnostic (we used to explicitly talk about static_cast), whereas
| Mark found the current status an improvement over the past, proposed
| some further, minor, improvements (which I tried to implement in the
| below)
| 
| Today I noticed that current ICC, clang, OracleStudio, all produce
| diagnostic quite similar, modulo the latter improvements, to GCC and
| decided to explore whether Gaby (and Jason) would like to reassess the
| bug, whether today we want to talk about dynamic_cast.
| 
| Tested x86_64-linux.
| 
| Thanks,
| Paolo.

I still consider talk of 'static_cast' in this context a non-starter.
However, maybe just saying "convert" would be OK -- though clearly
giving hints of dynamic_cast is much better.

Minor nits:  say "base class" instead of "base", and "derived class"
instead of "derived type".

Otherwise, patch OK with these suggestions.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]