This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix missing use of -Werror when compiling files in c-familty directory
- From: Chung-Ju Wu <jasonwucj at gmail dot com>
- To: "Balaji V. Iyer" <balaji dot v dot iyer at intel dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Graham Stott <graham dot stott at btinternet dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 4 Jul 2013 00:13:08 +0800
- Subject: Re: Fix missing use of -Werror when compiling files in c-familty directory
- References: <1372861690 dot 74458 dot YahooMailNeo at web87402 dot mail dot ir2 dot yahoo dot com> <Pine dot LNX dot 4 dot 64 dot 1307031453010 dot 18167 at digraph dot polyomino dot org dot uk> <CADj25HPEN-zWSY2-C3WvhrECm-bN1-_WGH5oTnc=46NNLrM9mg at mail dot gmail dot com>
2013/7/4 Chung-Ju Wu <jasonwucj@gmail.com>:
>> On Wed, 3 Jul 2013, Graham Stott wrote:
>>
>>> Files in the c-family directory are being compiled during stage3 without
>>> -Werror and other warningb flags that are part of WARN_STRICT flags.
>>> Fixing this shows that array_notation_common.c generates unused
>>> variable warnings and will break the build after the apcth is applied.
>>>
> But in the revision r200554: http://gcc.gnu.org/r200554
> you removed following two statements:
> l_node = int_cst_value (list[ii][jj].length);
> l_length = int_cst_value (length);
> causing l_length & l_node to be unused variables.
>
> I think it is safe to remove the declaration to avoid warning
> after r200554. What do you think? :-)
>
>
A-ha~ great, I just noticed Graham has posted the patch:
http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00132.html
Best regards,
jasonwucj