This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix for PR c/57490

From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
To: "Iyer\, Balaji V" <balaji dot v dot iyer at intel dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Marek Polacek \(polacek\ at redhat dot com\)" <polacek at redhat dot com>
Date: Wed, 03 Jul 2013 11:11:55 +0200
Subject: Re: [PATCH] Fix for PR c/57490
References: <BF230D13CA30DD48930C31D4099330003A43C80E at FMSMSX101 dot amr dot corp dot intel dot com> <20130701162401 dot GY2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C87D at FMSMSX101 dot amr dot corp dot intel dot com> <20130701170926 dot GB2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C8C0 at FMSMSX101 dot amr dot corp dot intel dot com>

"Iyer, Balaji V" <balaji.v.iyer@intel.com> writes:

>> -----Original Message-----
>> From: Jakub Jelinek [mailto:jakub@redhat.com]
>> Sent: Monday, July 01, 2013 1:09 PM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org; Rainer Orth
>> Subject: Re: [PATCH] Fix for PR c/57490
>> 
>> On Mon, Jul 01, 2013 at 05:02:57PM +0000, Iyer, Balaji V wrote:
>> > OK. The fixed patch is attached. Here are the ChangeLog entries:
>> >
>> > gcc/cp/ChangeLog
>> > 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>> >
>> 
>> Still
>> 	PR c/57490
>> hasn't been added to cp/ChangeLog and c/ChangeLog entries.
>> > --- /dev/null
>> > +++ b/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c
>> > @@ -0,0 +1,25 @@
>> 
>
> Fixed as you suggested. Here is the fixed Changelogs and patch is attached.
>
> gcc/cp/ChangeLog
> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>
>         PR c/57490
>         * cp-array-notation.c (cp_expand_cond_array_notations): Added a
>         check for truth values.
>         (expand_array_notation_exprs): Added truth values case.  Removed an
>         unwanted else.  Added for-loop to walk through subtrees in default
>         case.
>
> gcc/c/ChangeLog
> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>
>         PR c/57490
>         * c-array-notation.c (fix_conditional_array_notations_1): Added a
>         check for truth values.
>         (expand_array_notation_exprs): Added truth values case.  Removed an
>         unwanted else.  Added for-loop to walk through subtrees in default
>         case.
>
>
> gcc/testsuite/ChangeLog
> 2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>
>         PR c/57490
>         * c-c++-common/cilk-plus/AN/pr57490.c: New test.

I've just tested this patch on i386-pc-solaris2.10:

The c-c++-common/cilk-plus/AN/an-if.c test still FAILs for C++:

FAIL: c-c++-common/cilk-plus/AN/an-if.c  -fcilkplus (internal compiler error)
FAIL: c-c++-common/cilk-plus/AN/an-if.c  -fcilkplus (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2198 == 24) goto <D.2270>; else goto <D.2273>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2200 == D.2282) goto <D.2279>; else goto <D.2283>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2202 == 0) goto <D.2289>; else goto <D.2292>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2205 == 24) goto <D.2326>; else goto <D.2329>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2207 == D.2338) goto <D.2335>; else goto <D.2339>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: error: mismatching comparison operand types
float
int
if (D.2209 == iftmp.16) goto <D.2345>; else goto <D.2354>;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/an-if.c:13:5: internal compiler error: verify_gimple failed
0x87f1a27 verify_gimple_in_seq(gimple_statement_d*)
	/vol/gcc/src/hg/trunk/local/gcc/tree-cfg.c:4474
0x863ce54 gimplify_body(tree_node*, bool)
	/vol/gcc/src/hg/trunk/local/gcc/gimplify.c:8240
0x863d19a gimplify_function_tree(tree_node*)
	/vol/gcc/src/hg/trunk/local/gcc/gimplify.c:8325
0x84a9437 analyze_function
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:631
0x84ac97a analyze_functions
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:914
0x84ae029 finalize_compilation_unit()
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:2097
0x829255f cp_write_global_declarations()
	/vol/gcc/src/hg/trunk/local/gcc/cp/decl2.c:4356

WARNING: c-c++-common/cilk-plus/AN/an-if.c  -fcilkplus compilation failed to produce executable

While the C an-if.c test now passes, the new pr57490.c test (which is
identical to an-if.c modulo the assert to __builtin_abort change) FAILs:

FAIL: c-c++-common/cilk-plus/AN/pr57490.c  -fcilkplus -std=c99 (internal compiler error)
FAIL: c-c++-common/cilk-plus/AN/pr57490.c  -fcilkplus -std=c99 (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: error: invalid types in conversion to floating point
long double
float
D.1656 = (long double) D.1604;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: error: invalid types in conversion to floating point
long double
float
D.1671 = (long double) D.1609;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: error: invalid types in conversion to floating point
long double
float
D.1731 = (long double) D.1619;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: error: invalid types in conversion to floating point
long double
float
D.1746 = (long double) D.1624;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: error: invalid types in conversion to floating point
long double
float
D.1763 = (long double) D.1629;
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c:6:5: internal compiler error: verify_gimple failed
0x8612127 verify_gimple_in_seq(gimple_statement_d*)
	/vol/gcc/src/hg/trunk/local/gcc/tree-cfg.c:4474
0x845ca04 gimplify_body(tree_node*, bool)
	/vol/gcc/src/hg/trunk/local/gcc/gimplify.c:8240
0x845cd4a gimplify_function_tree(tree_node*)
	/vol/gcc/src/hg/trunk/local/gcc/gimplify.c:8325
0x82c8de7 analyze_function
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:631
0x82cc32a analyze_functions
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:914
0x82cd9d9 finalize_compilation_unit()
	/vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:2097
0x8196d8c c_write_global_declarations()
	/vol/gcc/src/hg/trunk/local/gcc/c/c-decl.c:10119

WARNING: c-c++-common/cilk-plus/AN/pr57490.c  -fcilkplus -std=c99 compilation failed to produce executable

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Follow-Ups:
- Re: [PATCH] Fix for PR c/57490
  - From: Rainer Orth

References:
- [PATCH] Fix for PR c/57490
  - From: Iyer, Balaji V
- Re: [PATCH] Fix for PR c/57490
  - From: Jakub Jelinek
- RE: [PATCH] Fix for PR c/57490
  - From: Iyer, Balaji V
- Re: [PATCH] Fix for PR c/57490
  - From: Jakub Jelinek
- RE: [PATCH] Fix for PR c/57490
  - From: Iyer, Balaji V

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]