This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: SSA identifiers

From: Andrew MacLeod <amacleod at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>
Date: Thu, 27 Jun 2013 14:52:08 -0400
Subject: Re: SSA identifiers
References: <51CC8391 dot 5000900 at redhat dot com> <20130627183940 dot GG2336 at tucnak dot redhat dot com>

On 06/27/2013 02:39 PM, Jakub Jelinek wrote:


in tree-ssanames.c:release_ssa_names() :

if (! SSA_NAME_IN_FREE_LIST (var))
     {
       tree saved_ssa_name_var = SSA_NAME_VAR (var);
       int saved_ssa_name_version = SSA_NAME_VERSION (var);
       use_operand_p imm = &(SSA_NAME_IMM_USE_NODE (var));
<..>
/* Hopefully this can go away once we have the new incremental
          SSA updating code installed.  */
       SET_SSA_NAME_VAR_OR_IDENTIFIER (var, saved_ssa_name_var);
I don't see a big issue with this, sure, you could
tree saved_ssa_name_identifier = saved_ssa_name_var ? saved_ssa_name_var : SSA_NAME_IDENTIFIER (var);
and use that instead in SET_SSA_NAME_VAR_OR_IDENTIFIER.

Yeah I wasn't too concerned about this one, the outof-ssa case lookedlike more of a possible issue. Maybe neither is, they just popped outas inconsistent uses.


Andrew

References:
- SSA identifiers
  - From: Andrew MacLeod
- Re: SSA identifiers
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]