This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [c++-concepts] code review
- From: Andrew Sutton <andrew dot n dot sutton at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Gabriel Dos Reis <gdr at axiomatics dot org>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Jun 2013 10:50:09 -0500
- Subject: Re: [c++-concepts] code review
- References: <CANq5Syt5s-NgazOYbT5wtYSRsbZUqcivoer1w4jiucx5qYKMfA at mail dot gmail dot com> <CANq5SystWWs=AOAYAHmRjfx17itDrYQj+GtdUr=-XYGLV_4=6g at mail dot gmail dot com> <51B0F122 dot 6020301 at redhat dot com> <CANq5SysFjY39osn-Xp3HXE-Due7C=D2-VKrhjKdLtpws8rH=mg at mail dot gmail dot com> <51B62961 dot 1080409 at redhat dot com> <CAAiZkiDY5LZRwgEAmc1VPhbMXJ1ytU_Q2Fj9tSyN1M_T7NMMfw at mail dot gmail dot com> <51B8A36C dot 1080005 at redhat dot com> <CANq5SyuWOKxWshSBb8uxtN8d6HMgifJdDcQSrsSwazRjE=v2NQ at mail dot gmail dot com> <51BBC613 dot 5040708 at redhat dot com> <CANq5SysgoJ0nVdrqLMjFqaWcmz97dB03qbKCs_ZpoBS+OVYzfg at mail dot gmail dot com> <51BF617D dot 3080101 at redhat dot com> <CANq5SyshsCtsQgGvCj6hVexa4m-st0-yM1PpLq=R68YXkfz_aw at mail dot gmail dot com> <51C1BE59 dot 6040400 at redhat dot com> <CAAiZkiDBrBMhRf-6w6dH1Yh7m6pOoJFEor38mcWKgtbzVXLhVA at mail dot gmail dot com> <51C2FD43 dot 8090209 at redhat dot com> <87bo716ia0 dot fsf at euclid dot axiomatics dot org> <CANq5SysuEbi34bd-05JsyiM4quYt7LevLd=zXinxvFAhnvEXGg at mail dot gmail dot com> <51C30A3C dot 2040907 at redhat dot com> <CANq5SyssNx96LxY2fe7_8QHVLCit2GMT3euZ4XJP2Z8Yx9cJaA at mail dot gmail dot com> <51C31CEA dot 2040208 at redhat dot com>
> The c++-concepts SVN branch won't come in with a clone; you need to add it
> to the fetch list with
>
> git config --add remote.origin.fetch
> refs/remotes/c++-concepts:refs/remotes/origin/c++-concepts
>
> Then you can check out a local branch based on it.
Already did that. I probably need to do this, right?
git checkout -b c++-concepts origin/c++-concepts
>> How will this change the workflow? What's the process for submitting
>> changes using git?
>
>
> That depends whether you want to keep it as an SVN branch or switch to a
> git-only branch. Both processes are documented in the wiki page:
>
> http://gcc.gnu.org/wiki/GitMirror#Commit_upstream_.28git-svn.29
> http://gcc.gnu.org/wiki/GitMirror#Git-only_branches
>
> If it's unclear, please let me know so I can update the page.
I just setup using a git-only branch, so the latter. I set up to push
changes to asutton/c++-concepts, so submitted should be visible there.
Out of curiosity, how will reviews work? Just walk through the most
recently pushed changes on my branch?
I should be able to produce diffs to send to Gaby also. I should also
be able to use those to patch an SVN checkout and commit from a
different repo.
Andrew