This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] libitm: Fix handling of reentrancy in the HTM fastpath
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, Richard Henderson <rth at redhat dot com>, andi <andi at firstfloor dot org>
- Date: Thu, 20 Jun 2013 08:49:37 -0500
- Subject: Re: [patch] libitm: Fix handling of reentrancy in the HTM fastpath
- References: <1371653823 dot 16968 dot 25276 dot camel at triegel dot csb> <1371656952 dot 5516 dot 19 dot camel at otta> <1371657476 dot 5516 dot 26 dot camel at otta> <1371670987 dot 5516 dot 181 dot camel at otta> <1371682261 dot 964 dot 3 dot camel at triegel dot csb> <1371697987 dot 5516 dot 200 dot camel at otta> <1371721764 dot 964 dot 468 dot camel at triegel dot csb>
On Thu, 2013-06-20 at 11:49 +0200, Torvald Riegel wrote:
> You're right, that was missing for x86 as well. Please see the updated
> second patch that is attached. It additionally checks htm_fastpath to
> see whether we are actually using the HTM. This variable is initialized
> to the value that htm_init() returns. This should do the right thing I
> suppose.
Of course you're right too. I totally missed we were already caching
that value. Ok, I removed the unneeded call to htm_available() in my
htm_transaction_active() and all is well using your second patch.
Thanks again!
Peter