This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [c++-concepts] code review
- From: Gabriel Dos Reis <gdr at axiomatics dot org>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Andrew Sutton <andrew dot n dot sutton at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Jun 2013 08:09:11 -0500
- Subject: Re: [c++-concepts] code review
- References: <CANq5Syt5s-NgazOYbT5wtYSRsbZUqcivoer1w4jiucx5qYKMfA at mail dot gmail dot com> <CAAiZkiAn9rpPmPKXztUA4rd3CH6w3=tn7jz=oksk65Ypx6RpGg at mail dot gmail dot com> <51B0B0ED dot 5090508 at redhat dot com> <CANq5SystWWs=AOAYAHmRjfx17itDrYQj+GtdUr=-XYGLV_4=6g at mail dot gmail dot com> <51B0F122 dot 6020301 at redhat dot com> <CANq5SysFjY39osn-Xp3HXE-Due7C=D2-VKrhjKdLtpws8rH=mg at mail dot gmail dot com> <51B62961 dot 1080409 at redhat dot com> <CAAiZkiDY5LZRwgEAmc1VPhbMXJ1ytU_Q2Fj9tSyN1M_T7NMMfw at mail dot gmail dot com> <51B8A36C dot 1080005 at redhat dot com> <CANq5SyuWOKxWshSBb8uxtN8d6HMgifJdDcQSrsSwazRjE=v2NQ at mail dot gmail dot com> <51BBC613 dot 5040708 at redhat dot com> <CANq5SysgoJ0nVdrqLMjFqaWcmz97dB03qbKCs_ZpoBS+OVYzfg at mail dot gmail dot com> <51BF617D dot 3080101 at redhat dot com> <CANq5SyshsCtsQgGvCj6hVexa4m-st0-yM1PpLq=R68YXkfz_aw at mail dot gmail dot com> <51C1BE59 dot 6040400 at redhat dot com> <CAAiZkiDBrBMhRf-6w6dH1Yh7m6pOoJFEor38mcWKgtbzVXLhVA at mail dot gmail dot com> <51C2FD43 dot 8090209 at redhat dot com>
Jason Merrill <jason@redhat.com> writes:
| On 06/20/2013 01:30 AM, Gabriel Dos Reis wrote:
| > As I discussed
| > with Andrew a couple of weeks ago, I have been holding back the
| > merge from trunk because he has these patch series in the queue.
|
| Incidentally, since the code is going onto a branch, we don't really
| need to delay checkins based on code review; I'd actually rather
| review the code from within git than from an email patch.
Makes sense. Andrew, you can check in what you have now, and refine
based on all other comments. I won't have network connection until
tonight; at that point I will do the merge from trunk. We don't want to
have the branch too old compared to the trunk.
-- Gaby