This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve folding of bitwise ops feeding conditionals for single bit types


On 19 June 2013 15:57, Jeff Law <law@redhat.com> wrote:
> On 06/19/2013 01:02 AM, Chung-Ju Wu wrote:
>>
>> 2013/6/19 Jeff Law <law@redhat.com>:
>>>
>>>
>>>          * gcc.dg/tree-ssa/forwprop-28.c: New test.
>>>
>>
>> In the gnu coding standard we have a space before
>> the open-parentheses.  Would that be great to have
>> testcase follow this convention as well? :)
>>
>> If so, then...
>
> No reason not to fix the test in this instance.  I'll make these updates
> before committing.

eh, nitpicking party ?

+   If a simplification is mode, return TRUE, else return FALSE.  */
+static bool
+simplify_bitwise_binary_boolean (gimple_stmt_iterator *gsi,

s/mode/made/

Sounds nice, otherwise!
thanks,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]