This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self

From: Matthias Klose <doko at ubuntu dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Meador Inge <meadori at codesourcery dot com>, Richard Biener <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 19 Jun 2013 17:29:42 +0200
Subject: Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self
References: <1349383546-25548-1-git-send-email-meadori at codesourcery dot com> <5074E123 dot 5070507 at codesourcery dot com> <5080208C dot 9050207 at codesourcery dot com> <508EA4CA dot 1030905 at codesourcery dot com> <509AD7E0 dot 2060008 at codesourcery dot com> <CAFiYyc3aiagqrNrTWN=sMr3KCCiTa6N48oD-5t+_x2Q46DmQ4w at mail dot gmail dot com> <50B502F9 dot 8020901 at codesourcery dot com> <51C19E16 dot 5040305 at ubuntu dot com> <20130619121026 dot GP2336 at tucnak dot redhat dot com>

Am 19.06.2013 14:10, schrieb Jakub Jelinek:
> On Wed, Jun 19, 2013 at 02:03:34PM +0200, Matthias Klose wrote:
>> Am 27.11.2012 19:14, schrieb Meador Inge:
>>> On 11/26/2012 09:05 AM, Richard Biener wrote:
>>>
>>>> On Wed, Nov 7, 2012 at 10:51 PM, Meador Inge <meadori@codesourcery.com> wrote:
>>>>> Ping ^ 4.
>>>>
>>>> Ok.
>>>
>>> Thanks for the review.  Committed to trunk.
>>
>> This did break gcc-ar and gcc-nm; now a regression on the 4.8 branch.
>>
>> $ gcc-ar-4.8 -h
>> gcc-ar-4.8: Cannot find plugin 'liblto_plugin.so'
>>
>> the plugin is *not* installed with x permission flags (which seems to be the
>> standard for shared libraries).   You did change the code to use find_a_file
>> which searches only for files with the x bit set.
> 
> That actually is the standard for shared libraries, the linker creates
> libraries with those permissions and libtool/automake installs them that way
> too.  So if you override this, you need to cope with that decision.

well, I did fix this assumption last year in gcc.c, then lets fix it in other
places too, just adding a mode parameter to the public find_a_file function.
Testing the attached patch.

  Matthias

Attachment: ff.diff
Description: Text document

Follow-Ups:
- Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self
  - From: Jakub Jelinek

References:
- Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self
  - From: Matthias Klose
- Re: [PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]