This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/4] Fix leading spaces.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Ondřej Bílka <neleai at seznam dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 13 Jun 2013 17:03:33 +0000
- Subject: Re: [PATCH 4/4] Fix leading spaces.
- References: <20130612195441 dot GA4848 at domone dot kolej dot mff dot cuni dot cz> <20130612200810 dot GD5447 at domone dot kolej dot mff dot cuni dot cz> <CAFiYyc2NQEg9KC2R+xcfUm5D-6AswewZzvytsHyrUJQ36TPDVA at mail dot gmail dot com>
On Thu, 13 Jun 2013, Richard Biener wrote:
> Btw, rather than these kind of patches I'd appreciate if someone would look
> at a simple pre(post?)-commit hook that enforces those whitespace rules.
In the cpp testsuite we definitely want tests with bad whitespace (e.g.
gcc.dg/cpp/backslash*.c) and generally I think it's wrong to be changing
whitespace in the testsuite without an understanding of what the test is
testing and how the whitespace is irrelevant to that (more generally,
cleanups of compiler tests are suspect without such an understanding of
what is or is not significant in a particular test). And so you need to
allow addition of otherwise bad whitespace there.
It's not obvious whether there might be other cases needing such
whitespace as well.
> Either by adjusting the committed content or by rejecting the commit(?)
I don't think hooks adjusting committed content are likely to work at all.
--
Joseph S. Myers
joseph@codesourcery.com