RE: [PATCH][ARM] PR56315 Improve codegen for DImode immediates - XOR

["Kyrylo Tkachov" <kyrylo dot tkachov at arm dot com>]

Oops, once again with patch attached...

gcc/
2013-06-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/56315
	* config/arm/arm.md (*xordi3_insn): Change to insn_and_split.
	(xordi3): Change operand 2 constraint to arm_xordi_operand.
	* config/arm/constraints.md (Dg): New constraint.
	* config/arm/neon.md (xordi3_neon): Remove.
	(neon_veor<mode>): Generate xordi3 instead of xordi3_neon.
	* config/arm/predicates.md (arm_xordi_operand): New predicate.


gcc/testsuite/
2013-06-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	PR target/56315
	* gcc.target/arm/xordi3-opt.c: New test.


> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> owner@gcc.gnu.org] On Behalf Of Kyrylo Tkachov
> Sent: 07 June 2013 14:03
> To: gcc-patches@gcc.gnu.org
> Cc: Ramana Radhakrishnan; Richard Earnshaw
> Subject: [PATCH][ARM] PR56315 Improve codegen for DImode immediates
> - XOR
> 
> Hi all,
> 
> In a similar vein to
> http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01838.html this patch
> lets
> us use the immediate forms of the eor instruction when dealing with
> 64-bit constants.
> The insn is changed into an insn_and_split and merged with the NEON
> version. A new constraint is introduced to make sure the pattern
> accepts
> the correct range of immediates.
> 
> Now for code:
>   unsigned long long xor64 (unsigned long long input)
>   {
>     return input ^ 0x200000004ULL;
>   }
> 
> we generate:
>          eor     r0, r0, #4
>          eor     r1, r1, #2
> 
> without any mov immediates.
> 
> Regtested arm-none-eabi on qemu with and without -mthumb.
> 
> Ok for trunk?
> 
> Thanks,
> Kyrill
> 
> gcc/
> 2013-06-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
> 	PR target/56315
> 	* config/arm/arm.md (*xordi3_insn): Change to insn_and_split.
> 	(xordi3): Change operand 2 constraint to arm_xordi_operand.
> 	* config/arm/constraints.md (Dg): New constraint.
> 	* config/arm/neon.md (xordi3_neon): Remove.
> 	(neon_veor<mode>): Generate xordi3 instead of xordi3_neon.
> 	* config/arm/predicates.md (arm_xordi_operand): New
> predicate.
> 
> 
> gcc/testsuite/
> 2013-06-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
> 	PR target/56315
> 	* gcc.target/arm/xordi3-opt.c: New test.
> 
> 
>

Attachment: xordi.patch
Description: Binary data