This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix parsing bug in validate_patches.py

From: Diego Novillo <dnovillo at google dot com>
To: Brooks Moses <bmoses at google dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Simon Baldwin <simonb at google dot com>
Date: Tue, 04 Jun 2013 18:57:43 -0400
Subject: Re: [patch] Fix parsing bug in validate_patches.py
References: <51A8F054 dot 4040503 at google dot com>

On 2013-05-31 14:47 , Brooks Moses wrote:

Index: contrib/testsuite-management/validate_failures.py
===================================================================
--- contrib/testsuite-management/validate_failures.py    (revision 199390)
+++ contrib/testsuite-management/validate_failures.py    (working copy)
@@ -120,7 +120,7 @@
   def __init__(self, summary_line, ordinal=-1):
     try:
       self.attrs = ''
-      if '|' in summary_line:

+ if '|' in summary_line and not_VALID_TEST_RESULTS_REX.match(summary_line):

OK with this predicate factored into a predicate function (maybeSummaryLineHasAttributes?)



Thanks.  Diego.

Follow-Ups:
- Re: [patch] Fix parsing bug in validate_patches.py
  - From: Brooks Moses

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]