This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

From: Yuri Rumyantsev <ysrumyan at gmail dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Igor Zamyatin <izamyatin at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Areg Melik-Adamyan <areg dot melikadamyan at gmail dot com>
Date: Mon, 3 Jun 2013 17:00:38 +0400
Subject: Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont
References: <CAEoMCqSRfUxCWksrKyjLbHh_DkJmU7seq7kYiDAHZ5bh6M1Fpw at mail dot gmail dot com> <CAFULd4bQou5YXHMU-j=gPvA3-Qrr=Yr_COx5JmBQ-YVwE4dE2Q at mail dot gmail dot com> <CAKdSQZmLcC3jMgSgc=+L3tswcdN0=JFpt8nDqMzaivcn8ZVLKw at mail dot gmail dot com> <CAFULd4YSv5YY4wcvU8jJXAODFMe_FDmn5noins2BEt-Rn9T1dQ at mail dot gmail dot com> <CAKdSQZk4jysKY5oSbs2_7DtjdCN5J-zvTVko2miEPvw8MhF7ag at mail dot gmail dot com> <20130601135255 dot GA1493 at tucnak dot redhat dot com> <20130601141009 dot GB1493 at tucnak dot redhat dot com>

Hi, Jakub!

Thanks a lot for you remarks!

Attached is the patch which fixes all of them.

Ok to install if all testing passes?

Changelog:

gcc/

2013-06-03 Yuri Rumyantsev  <yuri.s.rumyantsev@intel.com>

        *  config/i386/i386.c (ix86_lea_outperforms): Fix formatting.
        (ix86_avoid_lea_for_addr): Likewise.
        (exact_dependency_1): Likewise.
        (ix86_adjust_cost): Likewise.
        (swap_top_of_ready_list): Fix formatting and !reload_completed check
        removed.
        (do_reorder_for_imul): Fix typo, formatting and
        !reload_completed check removed.
        (ix86_sched_reorder): Fix typo and formatting.
        (fold_builtin_cpu): Move M_INTEL_SLM at the end of processor types
        list.

libgcc/

2013-06-03  Yuri Rumyantsev  <yuri.s.rumyantsev@intel.com>

        * config/i386/cpuinfo.c (INTEL_SLM): New enum value.

--------------------

2013/6/1 Jakub Jelinek <jakub@redhat.com>:
> On Sat, Jun 01, 2013 at 03:52:55PM +0200, Jakub Jelinek wrote:
>> On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote:
>> > Like this?
>>
>> Sorry for nitpicking, but there are various formatting issues.
>
> Also:
>       if (clock1 == clock2)
>       {
>         /* Determine winner - load must win. */
>         enum attr_memory memory1, memory2;
>         memory1 = get_attr_memory (top);
>         memory2 = get_attr_memory (next);
>         if (memory2 == MEMORY_LOAD && memory1 != MEMORY_LOAD)
>           return true;
>       }
> should indent { by 2 columns (i.e. use tab) from if, the body
> shouldbe moved 2 extra columns to the right and } as well.
>
> And there is i>= 0 in the patch (missing space after i).
>
> No idea why you do if (!reload_completed) return something;
> in swap_top_of_ready_list and do_reoder_for_imul, when those
> functions are only ever called from ix86_sched_reorder which bails
> out early if !reload_completed.
>
>         Jakub

Attachment: gcc_slm_patch3_2_review.patch
Description: Binary data

Follow-Ups:
- Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont
  - From: Jakub Jelinek

References:
- Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont
  - From: Jakub Jelinek
- Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]