This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont


On Sat, Jun 01, 2013 at 03:52:55PM +0200, Jakub Jelinek wrote:
> On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote:
> > Like this?
> 
> Sorry for nitpicking, but there are various formatting issues.

Also:
      if (clock1 == clock2)
      {
        /* Determine winner - load must win. */
        enum attr_memory memory1, memory2;
        memory1 = get_attr_memory (top);
        memory2 = get_attr_memory (next);
        if (memory2 == MEMORY_LOAD && memory1 != MEMORY_LOAD)
          return true;
      }
should indent { by 2 columns (i.e. use tab) from if, the body
shouldbe moved 2 extra columns to the right and } as well.

And there is i>= 0 in the patch (missing space after i).

No idea why you do if (!reload_completed) return something;
in swap_top_of_ready_list and do_reoder_for_imul, when those
functions are only ever called from ix86_sched_reorder which bails
out early if !reload_completed.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]