This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PING]RE: [patch] cilkplus: Array notation for C patch
- From: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Aldy Hernandez <aldyh at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, "rth at redhat dot com" <rth at redhat dot com>, "'Joseph S. Myers'" <joseph at codesourcery dot com>, 'gcc-patches' <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 28 May 2013 18:44:03 +0000
- Subject: RE: [PING]RE: [patch] cilkplus: Array notation for C patch
- References: <519D0180 dot 5030203 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A427882 at FMSMSX101 dot amr dot corp dot intel dot com> <20130523190349 dot GD1377 at tucnak dot redhat dot com> <519E6CA2 dot 9070402 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A427B8A at FMSMSX101 dot amr dot corp dot intel dot com> <519F935E dot 3080107 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A427E35 at FMSMSX101 dot amr dot corp dot intel dot com> <20130524180247 dot GC1377 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A427E9C at FMSMSX101 dot amr dot corp dot intel dot com> <51A4DD4C dot 3040708 at redhat dot com> <20130528165031 dot GQ1377 at tucnak dot redhat dot com>
Hi Richard, Jakub et al..
I think I have fixed everything requested by RTH (http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01400.html). I think I have also moved the tests in the correct place Jakub requested. It is passing all the correct regression tests and not affecting others.
Is this patch OK for trunk?
Thanks,
Balaji V. Iyer.
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> owner@gcc.gnu.org] On Behalf Of Jakub Jelinek
> Sent: Tuesday, May 28, 2013 12:51 PM
> To: Aldy Hernandez
> Cc: Iyer, Balaji V; Jeff Law; rth@redhat.com; 'Joseph S. Myers'; 'gcc-patches'
> Subject: Re: [PING]RE: [patch] cilkplus: Array notation for C patch
>
> On Tue, May 28, 2013 at 11:37:32AM -0500, Aldy Hernandez wrote:
> > > I moved all the tests from gcc.dg/cilk-plus/AN directory to c-c++-
> common/cilk-plus/AN directory. The gcc.dg/cilk-plus directory just contains cilk-
> plus.exp script, which will handle all the tests in cilk-plus, not just array notation
> (when the others are checked in that is). Is this what you requested?
> > ...
> > ...
> > > * c-c++-common/cilk-plus/AN/gather_scatter.c: Likewise.
> > > * c-c++-common/cilk-plus/AN/n-ptr-test.c: Likewise.
> > > * c-c++-common/cilk-plus/AN/side-effects-1.c: Likewise.
> > > * c-c++-common/cilk-plus/AN/test_builtin_return.c: Likewise.
> > > * c-c++-common/cilk-plus/AN/test_sec_limits.c: Likewise.
> > > * gcc.dg/cilk-plus/cilk-plus.exp: New script.
> >
> > Yes, I believe that's what Jakub is requesting. Basically, what we
> > want is that common tests that should work on both C and C++ go inside
> > the c-c++-common infrastructure, and thus have one test that stresses
> > both front ends.
> >
> > However, you may still need some gcc.dg/cilk-plus/* directory with
> > corresponding infrastructure if you have any tests that are exclusive
> > to C (and when you have C++ specific tests, corresponding
> > g++.dg/cilk-plus infrastructure).
> >
> > I'm curious, since you currently don't have any array notation support
> > for C++, the above patch should give lots of errors when it tries to
> > test the cilkplus tests on C++. Does it not give you errors? For now
> > you may need some conditional to avoid running the tests on C++ until
> > you get the C++ FE changes reviewed and approved.
>
> No, until g++.dg/cilk-plus/cilk-plus.exp is added, there is no *.exp file that will
> run the c-c++-common/cilk-plus/ tests for C++, so they will be run for C only.
>
> Jakub