This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: fix rtl-optimization/56833
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Joern Rennecke <joern dot rennecke at embecosm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Alexandre Oliva <aoliva at redhat dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Date: Mon, 27 May 2013 09:29:27 +0200
- Subject: Re: RFA: fix rtl-optimization/56833
- References: <20130515110002 dot j5o6zwvv8c88c48g-nzlynne at webmail dot spamcop dot net> <2394107 dot Rmvsi6zS5q at polaris> <20130524123313 dot 7wpimwjvi8w0o4cw-nzlynne at webmail dot spamcop dot net>
> Please find attached the updated patch.
Thanks. Still, although reg_mode[regno] is indeed tested above, in
+ for (i = hard_regno_nregs[regno][mode] - 1; i > 0; i--)
+ if (reg_mode[i] != BLKmode)
+ return false;
this should be reg_mode[regno + i] instead of reg_mode[i].
And one the nice benefits of the switch to C++ is that you can now declare the
iteration variable within the 'for' construct. So, if you aren't planning to
backport the patch to branches prior to 4.8, you can use the idiom in the
newmove2add_record_mode and move2add_valid_value_p functions.
The patch is OK with these modifications if it still passes testing.
--
Eric Botcazou