This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Mark threshold arrays in bb-reorder.c as constant
- From: Chung-Ju Wu <jasonwucj at gmail dot com>
- To: David Malcolm <dmalcolm at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 24 May 2013 23:51:55 +0800
- Subject: Re: Mark threshold arrays in bb-reorder.c as constant
- References: <1369269035 dot 26167 dot 39 dot camel at surprise> <20130523045645 dot GM1377 at tucnak dot redhat dot com>
2013/5/23 Jakub Jelinek <jakub@redhat.com>:
> On Wed, May 22, 2013 at 08:30:35PM -0400, David Malcolm wrote:
>> The arrays of thresholds in gcc/bb-reorder.c appear not to have changed
>> since 2004 (in r80564).
>>
>> As part of my hope of quashing global state in gcc, I'd like to mark
>> them as const.
>>
>> Bootstrapped and tested on x86_64-unknown-linux-gnu against r199189, and
>> has the same test results as an unpatched bootstrap of that revision.
>>
>> OK to commit to trunk?
>>
>> 2013-05-21 David Malcolm <dmalcolm@redhat.com>
>>
>> * bb-reorder.c (branch_threshold): make const
>> (exec_threshold): ditto
>
> The ChangeLog formatting is bad. After ): should always be a capital letter
> and the description should end with dot. So:
>
> * bb-reorder.c (branch_threshold): Make const.
> (exec_threshold): Ditto.
>
> instead.
>
> Jakub
Hi, David,
There is a similar issue in the contrib/ChangeLog.
2013-05-21 David Malcolm <dmalcolm@redhat.com>
* repro_fail: filter out "-ignore SIGHUP" from the spawn lines
It would be great if you can fix them to make formatting consistent. :)
Best regards,
jasonwucj